Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: cuex default compiler will not report error if package crd not i… #82

Conversation

Somefive
Copy link
Collaborator

…nstalled

…nstalled

Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
@Somefive Somefive requested a review from FogDong as a code owner April 21, 2023 10:01
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5aa2ba8) 86.34% compared to head (a926427) 86.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   86.34%   86.34%           
=======================================
  Files          74       74           
  Lines        3288     3288           
=======================================
  Hits         2839     2839           
  Misses        344      344           
  Partials      105      105           
Flag Coverage Δ
unit-test 86.34% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cue/cuex/compiler.go 82.90% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Somefive Somefive merged commit 841accb into kubevela:main Apr 21, 2023
@Somefive Somefive deleted the fix/cuex-compiler-ignore-error-when-package-not-installed branch April 23, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants