Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support object,list(object) variable types #236

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

evanli18
Copy link
Contributor

Closes: #233
Signed-off-by: Evan Li evan.li97@outlook.com

@evanli18
Copy link
Contributor Author

@zzxwill
Copy link
Collaborator

zzxwill commented Jan 27, 2022

That's great. Please add some unit tests to cover the code change.

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #236 (c231477) into master (01e3ac0) will decrease coverage by 0.10%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
- Coverage   55.68%   55.57%   -0.11%     
==========================================
  Files          10       10              
  Lines        1153     1148       -5     
==========================================
- Hits          642      638       -4     
+ Misses        448      446       -2     
- Partials       63       64       +1     
Flag Coverage Δ
unit 55.57% <40.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/configuration/convert.go 62.50% <40.00%> (-1.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01e3ac0...c231477. Read the comment docs.

Closes: kubevela#233
Signed-off-by: Evan Li <evan.li97@outlook.com>
@evanli18
Copy link
Contributor Author

That's great. Please add some unit tests to cover the code change.

I fix the unit test.

Copy link
Collaborator

@zzxwill zzxwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature is significant! Thanks for your contribution.

@zzxwill zzxwill merged commit 4a8cafc into kubevela:master Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map type object are not getting read by terraform controller
2 participants