Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Initializes the UI plugin framework #719

Merged
merged 14 commits into from
Mar 27, 2023

Conversation

barnettZQG
Copy link
Collaborator

Description of your changes

This is a big PR, and includes some changes:

  1. Upgrade the yarn tool to v2, we need the workspace feature.
  2. Add a sub-project @velaux/data, this project will provide the data type definitions that are used by the plugin.
  3. Add a sub-project @velaux/ui, this project will provide the UI common component.
  4. Add a base plugin framework, and support to load the Page App plugin.

Note that the plugin framework is currently in an experimental state.

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
.pnp.loader.mjs Fixed Show fixed Hide fixed
const menus = workspace && props.userInfo ? menuService.loadMenus(workspace, props.userInfo) : [];
setMenus(menus);
});
}, [props.userInfo, path]);

Check warning

Code scanning / CodeQL

Client-side cross-site scripting (experimental)

(Experimental) This may be a cross-site scripting vulnerability due to [a user-provided value](1). Identified using machine learning.
.pnp.loader.mjs Fixed Show fixed Hide fixed
.pnp.loader.mjs Fixed Show fixed Hide fixed
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch coverage: 59.07% and project coverage change: -0.12 ⚠️

Comparison is base (c312e3f) 60.34% compared to head (c6236ea) 60.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #719      +/-   ##
==========================================
- Coverage   60.34%   60.22%   -0.12%     
==========================================
  Files          94       99       +5     
  Lines       17622    17965     +343     
==========================================
+ Hits        10634    10820     +186     
- Misses       5679     5803     +124     
- Partials     1309     1342      +33     
Flag Coverage Δ
apiserver-unittests 32.21% <40.50%> (+0.12%) ⬆️
server-e2e-tests 49.59% <53.31%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/server/config/config.go 0.00% <0.00%> (ø)
pkg/server/interfaces/api/dto/v1/types.go 57.89% <0.00%> (-15.44%) ⬇️
pkg/server/server.go 55.02% <0.00%> (-6.49%) ⬇️
pkg/server/utils/bcode/bcode.go 48.93% <0.00%> (-2.18%) ⬇️
pkg/plugin/types/plugin.go 33.33% <33.33%> (ø)
pkg/server/utils/http.go 81.81% <50.00%> (-7.08%) ⬇️
pkg/plugin/loader/loader.go 56.73% <56.73%> (ø)
pkg/server/domain/service/plugin.go 65.11% <65.11%> (ø)
pkg/server/interfaces/api/plugin.go 71.42% <71.42%> (ø)
pkg/plugin/registry/in_memory.go 95.74% <95.74%> (ø)
... and 3 more

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Copy link
Contributor

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add some extra files to gitignore

Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
@barnettZQG barnettZQG merged commit f7f1236 into kubevela:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants