-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Initializes the UI plugin framework #719
Conversation
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
const menus = workspace && props.userInfo ? menuService.loadMenus(workspace, props.userInfo) : []; | ||
setMenus(menus); | ||
}); | ||
}, [props.userInfo, path]); |
Check warning
Code scanning / CodeQL
Client-side cross-site scripting (experimental)
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
==========================================
- Coverage 60.34% 60.22% -0.12%
==========================================
Files 94 99 +5
Lines 17622 17965 +343
==========================================
+ Hits 10634 10820 +186
- Misses 5679 5803 +124
- Partials 1309 1342 +33
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
1265236
to
f677a9b
Compare
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
30a4499
to
6554464
Compare
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add some extra files to gitignore
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Description of your changes
This is a big PR, and includes some changes:
@velaux/data
, this project will provide the data type definitions that are used by the plugin.@velaux/ui
, this project will provide the UI common component.I have:
yarn lint
to ensure the frontend changes are ready for review.make reviewable
to ensure the server changes are ready for review.backport release-x.y
labels to auto-backport this PR if necessary.Special notes for your reviewer