Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Modifying Memory Units #792

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Fix: Modifying Memory Units #792

merged 1 commit into from
Apr 27, 2023

Conversation

jiaxiaolei007
Copy link
Contributor

@jiaxiaolei007 jiaxiaolei007 commented Apr 26, 2023

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Signed-off-by: jiaxiaolei <584736476@qq.com>
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.11 ⚠️

Comparison is base (22d4c14) 61.27% compared to head (3c1dd6b) 61.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #792      +/-   ##
==========================================
- Coverage   61.27%   61.16%   -0.11%     
==========================================
  Files         109      109              
  Lines       19129    19129              
==========================================
- Hits        11721    11700      -21     
- Misses       5966     5981      +15     
- Partials     1442     1448       +6     
Flag Coverage Δ
apiserver-unittests 33.71% <ø> (-0.11%) ⬇️
server-e2e-tests 49.85% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

Successfully created backport PR #794 for release-1.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants