Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Check the permission before request the compare API #802

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

barnettZQG
Copy link
Collaborator

Description of your changes

Fixes #790

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -11.40 ⚠️

Comparison is base (7bc6b2f) 61.22% compared to head (778901f) 49.83%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #802       +/-   ##
===========================================
- Coverage   61.22%   49.83%   -11.40%     
===========================================
  Files         109      109               
  Lines       19129    19129               
===========================================
- Hits        11712     9533     -2179     
- Misses       5975     8349     +2374     
+ Partials     1442     1247      -195     
Flag Coverage Δ
apiserver-unittests ?
server-e2e-tests 49.83% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 46 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chivalryq chivalryq merged commit 92d097c into kubevela:main Apr 28, 2023
15 of 16 checks passed
@github-actions
Copy link

Successfully created backport PR #805 for release-1.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]the account with “project list” permission open web sometime request forbidden api
2 participants