Feat: update workflow version and refactor the config provider #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonderflow
requested review from
FogDong,
leejanee and
Somefive
as code owners
Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
Somefive
force-pushed
the
updateconfig
branch
from
b3839c5
to
da143a0
Compare
Codecov ReportBase: 68.28% // Head: 68.24% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
==========================================
- Coverage 68.28% 68.24% -0.05%
==========================================
Files 49 48 -1
Lines 4326 4267 -59
==========================================
- Hits 2954 2912 -42
+ Misses 1011 1002 -9
+ Partials 361 353 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Somefive
changed the title
Somefive
approved these changes
Feb 6, 2023
FogDong
approved these changes
Feb 6, 2023
FogDong
pushed a commit
to FogDong/workflow
that referenced
this pull request
Mar 2, 2023
…ela#130) Update workflow version and refactor the config provider Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
FogDong
added a commit
that referenced
this pull request
Mar 2, 2023
…econcile (#144) * Feat: update workflow version and refactor the config provider (#130) Update workflow version and refactor the config provider Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com> * fix rebase Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> * Feat: watch event listener in controller for a faster reconcile (#131) Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> * fix rebase Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> --------- Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com> Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> Co-authored-by: Jianbo Sun <wonderflow@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jianbo Sun jianbo.sjb@alibaba-inc.com
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer