Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: watch event listener in controller for a faster reconcile #131

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Feb 7, 2023

Signed-off-by: FogDong dongtianxin.tx@alibaba-inc.com

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 67.40% // Head: 65.00% // Decreases project coverage by -2.40% ⚠️

Coverage data is based on head (563c1b5) compared to base (7135326).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   67.40%   65.00%   -2.40%     
==========================================
  Files          48       40       -8     
  Lines        4267     4184      -83     
==========================================
- Hits         2876     2720     -156     
- Misses       1030     1106      +76     
+ Partials      361      358       -3     
Flag Coverage Δ
e2etests ?
unit-test 65.00% <0.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/main.go 0.96% <0.00%> (-0.01%) ⬇️
controllers/workflowrun_controller.go 52.44% <0.00%> (-15.23%) ⬇️
pkg/tasks/discover.go 56.25% <0.00%> (-37.50%) ⬇️
...g/webhook/v1alpha1/workflowrun/mutating_handler.go 58.82% <0.00%> (-17.65%) ⬇️
pkg/providers/workspace/workspace.go 71.66% <0.00%> (-13.34%) ⬇️
pkg/providers/kube/handle.go 48.73% <0.00%> (-10.76%) ⬇️
pkg/tasks/template/load.go 67.56% <0.00%> (-8.11%) ⬇️
...webhook/v1alpha1/workflowrun/validating_handler.go 74.07% <0.00%> (-7.41%) ⬇️
pkg/cue/packages/package.go 58.65% <0.00%> (-7.22%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FogDong FogDong merged commit 2daa3cb into kubevela:main Feb 7, 2023
@FogDong
Copy link
Member Author

FogDong commented Mar 2, 2023

/backport 0.4

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Backport failed for release-0.4, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-0.4
git worktree add -d .worktree/backport-131-to-release-0.4 origin/release-0.4
cd .worktree/backport-131-to-release-0.4
git checkout -b backport-131-to-release-0.4
ancref=$(git merge-base 713532658196f053b7575e6388fa57d72a607407 563c1b52adacc70326354929a56378ad15df9ea4)
git cherry-pick -x $ancref..563c1b52adacc70326354929a56378ad15df9ea4

FogDong added a commit to FogDong/workflow that referenced this pull request Mar 2, 2023
…vela#131)

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
FogDong added a commit that referenced this pull request Mar 2, 2023
…econcile (#144)

* Feat: update workflow version and refactor the config provider (#130)

Update workflow version and refactor the config provider

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>

* fix rebase

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>

* Feat: watch event listener in controller for a faster reconcile (#131)

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>

* fix rebase

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>

---------

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
Co-authored-by: Jianbo Sun <wonderflow@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants