Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add stepGroupName to process.Context #151

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

yangsoon
Copy link
Contributor

@yangsoon yangsoon commented Mar 31, 2023

Description of your changes

This PR add stepGroupName for process.Context. The sub steps of step-group can use context. stepGroupName to get
the StepGroupName of the step-group.

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@yangsoon yangsoon force-pushed the feature/add-stepGroup-context branch from 8a0c6b3 to 388676e Compare April 6, 2023 02:06
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch coverage: 90.74% and project coverage change: -0.60 ⚠️

Comparison is base (c730c05) 67.48% compared to head (329a305) 66.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
- Coverage   67.48%   66.88%   -0.60%     
==========================================
  Files          49       50       +1     
  Lines        4505     4551      +46     
==========================================
+ Hits         3040     3044       +4     
- Misses       1071     1104      +33     
- Partials      394      403       +9     
Flag Coverage Δ
e2etests 22.15% <59.25%> (-0.64%) ⬇️
unit-test 64.36% <66.66%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/types/types.go 33.33% <ø> (ø)
pkg/cue/process/datamanager.go 80.00% <80.00%> (ø)
pkg/tasks/custom/task.go 70.45% <90.47%> (+0.83%) ⬆️
pkg/cue/process/handle.go 62.66% <100.00%> (+0.50%) ⬆️
pkg/tasks/builtin/step_group.go 66.94% <100.00%> (+4.81%) ⬆️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yangsoon yangsoon force-pushed the feature/add-stepGroup-context branch 2 times, most recently from ec56b2a to 8478897 Compare April 6, 2023 07:07
@yangsoon yangsoon marked this pull request as ready for review April 6, 2023 07:07
@yangsoon yangsoon force-pushed the feature/add-stepGroup-context branch from 8478897 to 443f72f Compare April 6, 2023 09:50
Signed-off-by: yangsoon <songyang.song@alibaba-inc.com>
@yangsoon yangsoon force-pushed the feature/add-stepGroup-context branch from 443f72f to 329a305 Compare April 6, 2023 09:51
@FogDong FogDong merged commit cd812ee into kubevela:main Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants