Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: fix the step group status if there's a suspending sub step #158

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Fix: fix the step group status if there's a suspending sub step #158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/tasks/builtin/step_group.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,12 +171,12 @@ func getStepGroupStatus(status v1alpha1.StepStatus, stepStatus v1alpha1.Workflow
return status, &types.Operation{Skip: true}
case status.Phase == v1alpha1.WorkflowStepPhaseFailed && status.Reason == types.StatusReasonTimeout:
return status, &types.Operation{Terminated: true}
case subStepCounts[string(v1alpha1.WorkflowStepPhaseSuspending)] > 0:
status.Phase = v1alpha1.WorkflowStepPhaseSuspending
case len(stepStatus.SubStepsStatus) < subTaskRunners:
status.Phase = v1alpha1.WorkflowStepPhaseRunning
case subStepCounts[string(v1alpha1.WorkflowStepPhaseRunning)] > 0:
status.Phase = v1alpha1.WorkflowStepPhaseRunning
case subStepCounts[string(v1alpha1.WorkflowStepPhaseSuspending)] > 0:
status.Phase = v1alpha1.WorkflowStepPhaseSuspending
case subStepCounts[string(v1alpha1.WorkflowStepPhasePending)] > 0:
status.Phase = v1alpha1.WorkflowStepPhasePending
case subStepCounts[string(v1alpha1.WorkflowStepPhaseFailed)] > 0:
Expand Down