Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: replace deprecated command with environment file #181

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Feat: replace deprecated command with environment file #181

merged 1 commit into from
Dec 18, 2023

Conversation

jongwooo
Copy link
Contributor

Description of your changes

Closes #180

Update workflows to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow files that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

echo ::set-output name=TAG::latest

TO-BE

echo "TAG=latest" >> $GITHUB_OUTPUT

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

None

Special notes for your reviewer

None

Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
Copy link

codecov bot commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d88eef) 66.76% compared to head (e6bff7a) 66.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   66.76%   66.76%           
=======================================
  Files          50       50           
  Lines        4553     4553           
=======================================
  Hits         3040     3040           
  Misses       1108     1108           
  Partials      405      405           
Flag Coverage Δ
e2etests 22.14% <ø> (ø)
unit-test 64.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FogDong FogDong merged commit ec3c20d into kubevela:main Dec 18, 2023
17 checks passed
@jongwooo jongwooo deleted the feat/replace-deprecated-command-with-environment-file branch December 18, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file
2 participants