Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix fill array with array in inputs #86

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Nov 14, 2022

Signed-off-by: FogDong dongtianxin.tx@alibaba-inc.com

Description of your changes

Fix: fix fill array with array in inputs

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

cc @chivalryq

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
Copy link
Member

@chivalryq chivalryq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 67.83% // Head: 67.88% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (e9a1740) compared to base (4ac7113).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   67.83%   67.88%   +0.05%     
==========================================
  Files          45       45              
  Lines        4094     4039      -55     
==========================================
- Hits         2777     2742      -35     
+ Misses        951      940      -11     
+ Partials      366      357       -9     
Flag Coverage Δ
e2etests 24.41% <0.00%> (+0.35%) ⬆️
unit-test 65.42% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/types/types.go 33.33% <ø> (ø)
pkg/cue/model/value/value.go 79.58% <100.00%> (+1.66%) ⬆️
pkg/tasks/custom/task.go 71.34% <100.00%> (+0.68%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@FogDong FogDong merged commit a7b9c55 into kubevela:main Nov 14, 2022
FogDong added a commit that referenced this pull request Jan 3, 2023
* Fix: fix fill array with array in inputs

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>

* deprecate fill value by script

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants