Fix: fix fill array with array in inputs

pkg/cue/model/value/value.go

@@ -319,7 +319,16 @@ func (val *Value) fillRawByScript(x string, path string) error {
 	if err != nil {
 		return err
 	}
-	v, err := val.MakeValue(raw + "\n" + a.v)
+	assemblerVal, err := val.MakeValue(a.v)
+	if err != nil {
+		return errors.WithMessage(err, "remake assembler value")
+	}
+	// open the list for assembler value
+	assemblerRaw, err := assemblerVal.String(sets.ListOpen)
+	if err != nil {
+		return err
+	}
+	v, err := val.MakeValue(raw + "\n" + assemblerRaw)
 	if err != nil {
 		return errors.WithMessage(err, "remake value")
 	}

pkg/cue/model/value/value_test.go

@@ -952,7 +952,26 @@ func TestFillByScript(t *testing.T) {
 		x: 100
 	}, {
 		name: "foo"
-	}]
+	}, ...]
+}
+`},
+		{
+			name: "insert array to array",
+			raw: `
+a: b: c: [{x: 100}, {x: 101}, {x: 102}, ...]`,
+			path: "a.b.c[0].value",
+			v:    `"foo"`,
+			expected: `a: {
+	b: {
+		c: [{
+			x:     100
+			value: "foo"
+		}, {
+			x: 101
+		}, {
+			x: 102
+		}, ...]
+	}
 }
 `,
 		},
@@ -967,9 +986,9 @@ func TestFillByScript(t *testing.T) {
 			y: [{
 				name:  "key"
 				value: "foo"
-			}]
+			}, ...]
 		}
-	}]
+	}, ...]
 }
 `,
 		},
@@ -1052,7 +1071,7 @@ func TestFillByScript(t *testing.T) {
 			raw:  `a: b: [{x: y:[{name: "key"}]}]`,
 			path: "a.b[0].x.y[0].value",
 			v:    `foo`,
-			err:  "remake value: a.b.x.y.value: reference \"foo\" not found",
+			err:  "remake assembler value: a.b.x.y.value: reference \"foo\" not found",
 		},
 		{
 			name: "conflict merge",
@@ -1066,7 +1085,7 @@ func TestFillByScript(t *testing.T) {
 			raw:  `a: b: [{x: y:[{name: "key"}]}]`,
 			path: "a.b[0].x.y[0].value",
 			v:    `*+-`,
-			err:  "remake value: expected operand, found '}'",
+			err:  "remake assembler value: expected operand, found '}'",
 		},
 	}
 

pkg/tasks/custom/task.go

@@ -194,7 +194,8 @@ func (t *TaskLoader) makeTaskGenerator(templ string) (types.TaskGenerator, error
 			for _, hook := range options.PreStartHooks {
 				if err := hook(ctx, basicVal, wfStep); err != nil {
 					tracer.Error(err, "do preStartHook")
-					return v1alpha1.StepStatus{}, nil, errors.WithMessage(err, "do preStartHook")
+					exec.err(ctx, false, err, types.StatusReasonInput)
+					return exec.status(), exec.operation(), nil
 				}
 			}
 

pkg/tasks/custom/task_test.go

@@ -263,9 +263,15 @@ close({
 		status, operation, err := run.Run(wfCtx, &types.TaskRunOptions{})
 		switch step.Name {
 		case "input-err":
-			r.Equal(err.Error(), "do preStartHook: parameter.score.x: conflicting values 100 and 101")
+			r.Equal(status.Message, "parameter.score.x: conflicting values 100 and 101")
+			r.Equal(operation.Waiting, false)
+			r.Equal(status.Phase, v1alpha1.WorkflowStepPhaseFailed)
+			r.Equal(status.Reason, types.StatusReasonInput)
 		case "input":
-			r.Equal(err.Error(), "do preStartHook: get input from [podIP]: failed to lookup value: var(path=podIP) not exist")
+			r.Equal(status.Message, "get input from [podIP]: failed to lookup value: var(path=podIP) not exist")
+			r.Equal(operation.Waiting, false)
+			r.Equal(status.Phase, v1alpha1.WorkflowStepPhaseFailed)
+			r.Equal(status.Reason, types.StatusReasonInput)
 		case "output-var-conflict":
 			r.Contains(status.Message, "conflict")
 			r.Equal(operation.Waiting, false)

pkg/types/types.go

@@ -258,6 +258,8 @@ const (
 	StatusReasonTerminate = "Terminate"
 	// StatusReasonParameter is the reason of the workflow progress condition which is ProcessParameter.
 	StatusReasonParameter = "ProcessParameter"
+	// StatusReasonInput is the reason of the workflow progress condition which is Input.
+	StatusReasonInput = "Input"
 	// StatusReasonOutput is the reason of the workflow progress condition which is Output.
 	StatusReasonOutput = "Output"
 	// StatusReasonFailedAfterRetries is the reason of the workflow progress condition which is FailedAfterRetries.