Merge pull request #1150 from hstastna/BZ_Improve_text_delete_modal_b…

…ootable_volumes Bug 2175983: Update text on Delete modal for bootable volumes
kubevirt-ui · Mar 16, 2023 · 0dcfde6 · 0dcfde6
2 parents 8e2e121 + fded0e5
commit 0dcfde6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/locales/en/plugin__kubevirt-plugin.json b/locales/en/plugin__kubevirt-plugin.json
@@ -327,7 +327,6 @@
   "Delete DataImportCron?": "Delete DataImportCron?",
   "Delete DataSource?": "Delete DataSource?",
   "Delete disks ({{diskCount}}x)": "Delete disks ({{diskCount}}x)",
-  "Delete labels?": "Delete labels?",
   "Delete MigrationPolicy?": "Delete MigrationPolicy?",
   "Delete NIC?": "Delete NIC?",
   "Delete Resource?": "Delete Resource?",
@@ -338,6 +337,8 @@
   "Delete VirtualMachineInstance": "Delete VirtualMachineInstance",
   "Delete VirtualMachineInstance?": "Delete VirtualMachineInstance?",
   "Delete VirtualMachineSnapshot?": "Delete VirtualMachineSnapshot?",
+  "Delete volume parameters?": "Delete volume parameters?",
+  "Deleting the parameters will mark this volume as non-bootable and remove it from the bootable volumes list. The volume will still be available in the cluster.": "Deleting the parameters will mark this volume as non-bootable and remove it from the bootable volumes list. The volume will still be available in the cluster.",
   "Deprecated": "Deprecated",
   "Descheduler": "Descheduler",
   "Descheduler settings": "Descheduler settings",
@@ -740,7 +741,6 @@
   "Please do not close this window, you can keep navigating the app freely.": "Please do not close this window, you can keep navigating the app freely.",
   "Please don't close this browser tab": "Please don't close this browser tab",
   "Please don’t close this browser tab": "Please don’t close this browser tab",
-  "Please note that only the labels data will be deleted and that the bootable volume will remain. Are you sure you want to delete the labels for bootable volume <2>{dataSource?.metadata?.name}</2>?": "Please note that only the labels data will be deleted and that the bootable volume will remain. Are you sure you want to delete the labels for bootable volume <2>{dataSource?.metadata?.name}</2>?",
   "Please provide hostname.": "Please provide hostname.",
   "Please select a boot source": "Please select a boot source",
   "Please wait, once the Data Volume has been created the data will start uploading into this Persistent Volume Claims.": "Please wait, once the Data Volume has been created the data will start uploading into this Persistent Volume Claims.",

diff --git a/src/views/bootablevolumes/actions/components/DeleteBootableVolumesModal.tsx b/src/views/bootablevolumes/actions/components/DeleteBootableVolumesModal.tsx
@@ -27,13 +27,12 @@ const DeleteBootableVolumesModal: FC<DeleteBootableVolumesModalProps> = ({
       obj={dataSource}
       isOpen={isOpen}
       onClose={onClose}
-      headerText={t('Delete labels?')}
+      headerText={t('Delete volume parameters?')}
       onDeleteSubmit={deleteBootableVolumeMetadata(dataSource)}
       bodyText={
         <Trans t={t}>
-          Please note that only the labels data will be deleted and that the bootable volume will
-          remain. Are you sure you want to delete the labels for bootable volume{' '}
-          <strong>{dataSource?.metadata?.name}</strong>?
+          Deleting the parameters will mark this volume as non-bootable and remove it from the
+          bootable volumes list. The volume will still be available in the cluster.
         </Trans>
       }
       redirectUrl={`/k8s/${lastNamespacePath}/bootablevolumes`}