Bug 2175983: Update text on Delete modal for bootable volumes #1150
Conversation
|
@hstastna: This pull request references Bugzilla bug 2175983, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@hstastna: This pull request references Bugzilla bug 2175983, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hstastna
force-pushed
the
BZ_Improve_text_delete_modal_bootable_volumes
branch
from
54c337c
to
91bf2fa
Compare
Update the title and the text of the Delete modal for bootable volumes: Modal title text: "Delete volume parameters?" Modal content: "Deleting the parameters will mark this volume as non-bootable and remove it from the bootable volumes list. The volume will still be available in the cluster." This change of the text is made according to the design changes, as the original text and the title of the modal weren't quite appropriate or clear enough to the user. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2175983
hstastna
force-pushed
the
BZ_Improve_text_delete_modal_bootable_volumes
branch
from
91bf2fa
to
fded0e5
Compare
|
@hstastna: This pull request references Bugzilla bug 2175983, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold Seems that the discussion about the proper text of the modal is still continuing... |
|
/hold cancel |
|
I'm removing "hold" from this PR, as the discussions regarding the text of the modal seem kinda like never ending story so let's merge what we have, it's already an improvement. |
|
@hstastna: All pull requests linked via external trackers have merged: Bugzilla bug 2175983 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
馃摑 Description
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2175983
Update the title and the text of the Delete modal for bootable volumes the following way:
Modal title text:
"Delete volume parameters?"
Modal content:
"Deleting the parameters will mark this volume as non-bootable and remove it from the bootable volumes list. The volume will still be available in the cluster.
This change of the text is made according to the design changes, as the original text and the title of the modal weren't quite appropriate or clear enough to the user.
Related design doc:
https://docs.google.com/document/d/15Cv54978AZKeukkurvkFN1YEx_kBsm_3XcmLey_cgZY/edit?disco=AAAAq58TGPw
Note:
"Are you sure you want to delete the parameters from bootable volume <volume_name>?" was not included in the text, because as discussed in the design doc, it wasn't necessary as this is not a destructive action (we're not deleting the whole resource/object, only a few params). Later when this part of the UI will be revisited regarding the question if we could completely delete the volume, then this text will be more relevant.
馃帴 Screenshots
Before:
After:
