Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2175983: Update text on Delete modal for bootable volumes #1150

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Bug 2175983: Update text on Delete modal for bootable volumes #1150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions locales/en/plugin__kubevirt-plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,6 @@
"Delete DataImportCron?": "Delete DataImportCron?",
"Delete DataSource?": "Delete DataSource?",
"Delete disks ({{diskCount}}x)": "Delete disks ({{diskCount}}x)",
"Delete labels?": "Delete labels?",
"Delete MigrationPolicy?": "Delete MigrationPolicy?",
"Delete NIC?": "Delete NIC?",
"Delete Resource?": "Delete Resource?",
Expand All @@ -338,6 +337,8 @@
"Delete VirtualMachineInstance": "Delete VirtualMachineInstance",
"Delete VirtualMachineInstance?": "Delete VirtualMachineInstance?",
"Delete VirtualMachineSnapshot?": "Delete VirtualMachineSnapshot?",
"Delete volume parameters?": "Delete volume parameters?",
"Deleting the parameters will mark this volume as non-bootable and remove it from the bootable volumes list. The volume will still be available in the cluster.": "Deleting the parameters will mark this volume as non-bootable and remove it from the bootable volumes list. The volume will still be available in the cluster.",
"Deprecated": "Deprecated",
"Descheduler": "Descheduler",
"Descheduler settings": "Descheduler settings",
Expand Down Expand Up @@ -740,7 +741,6 @@
"Please do not close this window, you can keep navigating the app freely.": "Please do not close this window, you can keep navigating the app freely.",
"Please don't close this browser tab": "Please don't close this browser tab",
"Please don鈥檛 close this browser tab": "Please don鈥檛 close this browser tab",
"Please note that only the labels data will be deleted and that the bootable volume will remain. Are you sure you want to delete the labels for bootable volume <2>{dataSource?.metadata?.name}</2>?": "Please note that only the labels data will be deleted and that the bootable volume will remain. Are you sure you want to delete the labels for bootable volume <2>{dataSource?.metadata?.name}</2>?",
"Please provide hostname.": "Please provide hostname.",
"Please select a boot source": "Please select a boot source",
"Please wait, once the Data Volume has been created the data will start uploading into this Persistent Volume Claims.": "Please wait, once the Data Volume has been created the data will start uploading into this Persistent Volume Claims.",
Expand Down
7 changes: 3 additions & 4 deletions src/views/bootablevolumes/actions/components/DeleteBootableVolumesModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,12 @@ const DeleteBootableVolumesModal: FC<DeleteBootableVolumesModalProps> = ({
obj={dataSource}
isOpen={isOpen}
onClose={onClose}
headerText={t('Delete labels?')}
headerText={t('Delete volume parameters?')}
onDeleteSubmit={deleteBootableVolumeMetadata(dataSource)}
bodyText={
<Trans t={t}>
Please note that only the labels data will be deleted and that the bootable volume will
remain. Are you sure you want to delete the labels for bootable volume{' '}
<strong>{dataSource?.metadata?.name}</strong>?
Deleting the parameters will mark this volume as non-bootable and remove it from the
bootable volumes list. The volume will still be available in the cluster.
</Trans>
}
redirectUrl={`/k8s/${lastNamespacePath}/bootablevolumes`}
Expand Down