Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNV-37814: Upgrade to PFv5 #1804

Merged
merged 1 commit into from Feb 26, 2024
Merged

CNV-37814: Upgrade to PFv5 #1804

merged 1 commit into from Feb 26, 2024

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Feb 19, 2024

馃摑 Description

Upgrading Patternfly to version 5.1.1
Upgrading SDK packages to 1.0.0 as they support PFv5

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 19, 2024 •
edited by openshift-ci bot

@avivtur: This pull request references CNV-37814 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

馃摑 Description

Upgrading Patternfly to version 5.1.1
Upgrading SDK packages to 1.0.0 as they support PFv5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Feb 19, 2024
@metalice
Copy link
Member

/retest

@metalice
Copy link
Member

/retest

@metalice
Copy link
Member

/test images

@metalice
Copy link
Member

managed to reproduce. trying to make a solution

@metalice
Copy link
Member

ok, I managed to figure it out; now it's working for me locally, but my laptop has 64 GB ram; I don't know the ci ram, lets hope its more then 8
let's try
image

u can remove this added line form package.json scripts.build

@avivtur
Copy link
Member Author

avivtur commented Feb 21, 2024

/test images

@hstastna
Copy link
Member

/retest

@hstastna
Copy link
Member

/retest

@avivtur
CNV-37814: Upgrade to PFv5
ac229c3 
Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@avivtur
Copy link
Member Author

avivtur commented Feb 26, 2024 •
edited

/unhold

@avivtur avivtur changed the title [WIP] CNV-37814: Upgrade to PFv5 CNV-37814: Upgrade to PFv5 Feb 26, 2024
@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Feb 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6575857 into kubevirt-ui:main Feb 26, 2024
9 checks passed
@vojtechszocs vojtechszocs mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hstastna hstastna Awaiting requested review from hstastna

@tnisan tnisan Awaiting requested review from tnisan

Assignees

@metalice metalice

Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@avivtur @openshift-ci-robot @metalice @hstastna @openshift-merge-robot