New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-30762: Fix bugs in Console dynamic plugin SDK webpack code #13657
OCPBUGS-30762: Fix bugs in Console dynamic plugin SDK webpack code #13657
Conversation
edf334a
to
2da5c34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhamilto, vojtechszocs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-gcp-console |
1 similar comment
/test e2e-gcp-console |
@vojtechszocs: This pull request references Jira Issue OCPBUGS-30759, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@vojtechszocs: This pull request references Jira Issue OCPBUGS-30762, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@vojtechszocs: This pull request references Jira Issue OCPBUGS-30762, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@vojtechszocs: This pull request references Jira Issue OCPBUGS-30762, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/test e2e-gcp-console |
/jira refresh |
@jhadvig: This pull request references Jira Issue OCPBUGS-30762, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@vojtechszocs: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@vojtechszocs: Jira Issue OCPBUGS-30762: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-30762 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-console-container-v4.16.0-202403122214.p0.g824a736.assembly.stream.el8 for distgit openshift-enterprise-console. |
Fix included in accepted release 4.16.0-0.nightly-2024-03-13-061822 |
This PR addresses several bugs in Console dynamic plugin SDK discovered as part of kubevirt-ui/kubevirt-plugin#1804
1. Build errors related to Hot Module Replacement chunk files
☑️ Fixed in openshift/dynamic-plugin-sdk#256 - updated
@openshift/dynamic-plugin-sdk-webpack
dependency.2. Build warnings issued by
dynamic-module-import-loader
ℹ️ Not all valid
.ts
files can be parsed usingScriptKind.TSX
- this is an inherent TS language limitation.☑️ Fixed by using
ScriptKind.TSX
only when parsing modules that end with.jsx
or.tsx
.3. Build warnings related to PatternFly shared modules
☑️ Fixed by allowing
@openshift-console/*
packages to have their code processed bydynamic-module-import-loader
.This PR also improves the performance of
dynamic-module-import-loader
to minimize the module parse overhead: