Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-38270: Changing snapshot status #1858

Conversation

metalice
Copy link
Member

📝 Description

Instead of looking on status.phase we will look from now on status.conditions , type of Ready, its a more accurate field.

🎥 Demo

Please add a video or an image of the behavior/changes

After:
image

Before:
image

Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 27, 2024

@metalice: This pull request references CNV-38270 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Instead of looking on status.phase we will look from now on status.conditions , type of Ready, its a more accurate field.

🎥 Demo

Please add a video or an image of the behavior/changes

After:
image

Before:
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Mar 27, 2024
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Mar 27, 2024
Copy link
Contributor

openshift-ci bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@avivtur
Copy link
Member

avivtur commented Apr 3, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 5ff8db8 into kubevirt-ui:main Apr 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants