-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update NetworkAddonsConfig Status field with conditions #29
Conversation
/hold |
Need to add monitoring of |
I resolved the reporting problem. Now we need to find out whether we can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
just a small nit
All tests passed |
@@ -55,17 +56,18 @@ func Add(mgr manager.Manager) error { | |||
} | |||
|
|||
// newReconciler returns a new reconcile.Reconciler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this comment be changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
return &ReconcileNetworkAddonsConfig{ | ||
client: mgr.GetClient(), | ||
scheme: mgr.GetScheme(), | ||
podReconciler: newPodReconciler(), | ||
sccIsAvailable: sccIsAvailable, | ||
} | ||
} | ||
|
||
// add adds a new Controller to mgr with r as the reconcile.Reconciler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
I can only applaud to the clarity of the code, all the comments describing the logic, the way PR is split into commits etc. Great stuff. |
😊 thanks |
This PR add a reconciliation for pods. This will be later used to update state based on components' pods.
In order to make code more readable and prepare it for status managing, we split Reconcile method of NetworkAddonsConfig operator into subfunctions.
This patch adds StatusManager which is responsible of updating NetworkAddonsConfig Status field with set of conditions. These conditions include Failing, Progressing and Ready. Failing indicates error either on rendering/applying level of NetworkAddonsConfig operator of an error that happened during deployment of components's pods. Progressing indicates on-going deployment of components. Ready set to True indicates that all components has been successfully deployed.
Some tests failed |
With this PR we update NetworkAddonsConfig Status field with set of
conditions. These conditions include Failing, Progressing and Ready.
Failing indicates error either on rendering/applying level of
NetworkAddonsConfig operator of an error that happened during deployment
of components's pods.
Progressing indicates on-going deployment of components.
Ready set to True indicates that all components has been successfully
deployed.
Failing Status field:
Progressing Status field:
Ready Status field: