Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a new NW Network instance type family #47

Closed
wants to merge 1 commit into from
Closed

Introduce a new NW Network instance type family #47

wants to merge 1 commit into from

Conversation

lyarwood
Copy link
Member

@lyarwood lyarwood commented Jun 13, 2023 •
edited

What this PR does / why we need it:

Introduces a new NW class of Network specific instance types.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #40

Special notes for your reviewer:

Based on #57

Release note:

A new `NW` class of instance types has been introduced focused on `Network Intensive` workloads.

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 13, 2023
@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jun 13, 2023
@lyarwood lyarwood added this to the v0.2.0 milestone Jun 13, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lyarwood. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lyarwood lyarwood force-pushed the network-instancetype-family branch from 0fe6582 to e61d386 Compare June 13, 2023 08:47
@lyarwood lyarwood modified the milestones: v0.2.0, v0.3.0, v0.2.1 Jun 14, 2023
@lyarwood lyarwood force-pushed the network-instancetype-family branch from e61d386 to f29179c Compare June 15, 2023 14:02
@lyarwood lyarwood marked this pull request as ready for review June 15, 2023 14:03
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2023
@lyarwood
Introduce a new NW Network focused instance type class
88d9841 
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
@lyarwood lyarwood force-pushed the network-instancetype-family branch from f29179c to 88d9841 Compare June 20, 2023 11:00
@lyarwood lyarwood changed the title Introduce a new Network instance type family Introduce a new NW Network instance type family Jun 20, 2023
@lyarwood
Copy link
Member Author

/cc @0xFelix

@0xFelix
Copy link
Member

0xFelix commented Jun 20, 2023

/cc @orelmisan Do you have any suggestions or requirements for networking related instancetypes?

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 20, 2023
@kubevirt-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lyarwood lyarwood removed this from the v0.3.0 milestone Jun 21, 2023
@lyarwood lyarwood added this to the v0.4.0 milestone Jun 21, 2023
@fabiand
Copy link
Member

fabiand commented Jun 21, 2023

Hm. Not n1?

@lyarwood
Copy link
Member Author

Hm. Not n1?

If #63 lands I'll switch this over to n.

@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 19, 2023
@kubevirt-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubevirt-bot kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 19, 2023
@0xFelix
Copy link
Member

0xFelix commented Nov 13, 2023

/remove-lifecycle rotten

@kubevirt-bot kubevirt-bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Nov 13, 2023
@0xFelix
Copy link
Member

0xFelix commented Nov 20, 2023

/close

Closed in favor of #123

@kubevirt-bot
Copy link
Contributor

@0xFelix: Closed this PR.

In response to this:

/close

Closed in favor of #123

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrejcir akrejcir Awaiting requested review from akrejcir

@ksimon1 ksimon1 Awaiting requested review from ksimon1

@0xFelix 0xFelix Awaiting requested review from 0xFelix

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

Introduce network workload specific instance types
4 participants
@lyarwood @kubevirt-bot @0xFelix @fabiand