Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use v1beta1 in base VirtualMachineInstancetype definition #57

Merged
merged 3 commits into from Jun 20, 2023
Merged

fix: Use v1beta1 in base VirtualMachineInstancetype definition #57

merged 3 commits into from Jun 20, 2023

Conversation

lyarwood
Copy link
Member

What this PR does / why we need it:

$ git grep -l instancetype.kubevirt.io/v1alpha2
common-instancetypes-all-bundle.yaml
common-instancetypes-bundle.yaml
common-instancetypes/instancetypes/base/VirtualMachineInstancetype.yaml

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #56

Special notes for your reviewer:

Release note:

NONE

@lyarwood
fix: Use v1beta1 in base VirtualMachineInstancetype definition
95fa32b 
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
@lyarwood lyarwood added this to the v0.3.0 milestone Jun 15, 2023
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 15, 2023
@lyarwood
Copy link
Member Author

/cc @0xFelix

@lyarwood lyarwood mentioned this pull request Jun 15, 2023
Closed
@lyarwood
Remove all remaining references to instancetype.kubevirt.io/v1alpha{1,2}
823007d 
These references don't actually change the generated resource output but
should be removed to avoid confusion.

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
@lyarwood lyarwood mentioned this pull request Jun 15, 2023
Merged
@ksimon1
Copy link
Member

ksimon1 commented Jun 16, 2023

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2023
0xFelix
0xFelix reviewed Jun 20, 2023
View reviewed changes
scripts/check.sh Outdated Show resolved Hide resolved
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2023
@lyarwood
check: Add instancetype.kubevirt.io version check
5ba7be3 
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
0xFelix
0xFelix approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2023
@kubevirt-bot kubevirt-bot merged commit 5cf2e7f into kubevirt:main Jun 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix approved these changes

@akrejcir akrejcir Awaiting requested review from akrejcir

@ksimon1 ksimon1 Awaiting requested review from ksimon1

Assignees

@0xFelix 0xFelix

@ksimon1 ksimon1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

Some resources still using instancetype.kubevirt.io/v1alpha2
4 participants
@lyarwood @ksimon1 @kubevirt-bot @0xFelix