Introduce preference resource requirements #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note
lyarwood
force-pushed
the
introduce-preference-resource-requirements
branch
from
92f3108
to
3142bf1
Compare
|
/hold |
kubevirt-bot
added
the
do-not-merge/hold
lyarwood
force-pushed
the
introduce-preference-resource-requirements
branch
from
3142bf1
to
6abe6cb
Compare
|
/unhold |
kubevirt-bot
removed
the
do-not-merge/hold
|
/cc @0xFelix |
|
How will you make sure the requirement are up to date? |
Great question, I had forgotten to document #59 and a move to |
|
/lgtm |
|
/hold As this is based on #57 |
kubevirt-bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/unhold |
kubevirt-bot
removed
the
do-not-merge/hold
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
Given that all preferences now have resource requirements we need to actually provide adequate resources to the VirtualMachine. A negative test is also added for each preference ensuring that requests to create a VirtualMachine using an instance type that doesn't provide enough resources are rejected. Additionally the use of virtctl is introduced, removing a long standing TODO from both the preference and instance type tests. Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
lyarwood
force-pushed
the
introduce-preference-resource-requirements
branch
from
6abe6cb
to
37dbb7e
Compare
kubevirt-bot
added
size/XL
and removed
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #55, fixes #51
Special notes for your reviewer:
Based on #57
Release note: