Adding support for import of vmdk and vdi file types

[visheshtanksale]

Signed-off-by: Vishesh Ajay Tanksale vtanksale@apple.com

What this PR does / why we need it:
Adds support to importer VMDK and VDI type of VM Images

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
Adding support to download and convert VMDK and VDI images
Release note:

Adding support to import vmdk and vdi VM Images

[kubevirt-bot]

Hi @visheshtanksale. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign awels
You can assign the PR to them by writing /assign @awels in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coveralls]

Coverage decreased (-0.04%) to 74.331% when pulling b2cea43 on visheshtanksale:vmdk-vdi-support into aa90f77 on kubevirt:master.

[awels]

Hi,
thanks for the PR. A few things to consider here:

• vmdk and vdi files will have drivers installed for their respective source hyper visors, and the conversion will not remove or modify them at all. So once the conversion is done, the VMs will likely be slower due to misconfigured drivers. In particular windows VMs will be like that.
• We documentation stating which combinations we support here that will need to get updated to include the new formats.
• We also want unit tests and functional tests for the new formats. We usually use small images like cirros or tinyCore for the tests. At a minimum I would add some importing tests in tests/datavolume_test.go. There should be ample examples of similar tests there. Its a little tricky adding new formats to the test http server, but I can help with that.