Add support for importing from VMDK, VDI, VHD, VHDX formats #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vishesh Ajay Tanksale <vtanksale@apple.com>
Signed-off-by: Maya Rashish <mrashish@redhat.com>
vmdk, vdi, vhd, vhdx. Signed-off-by: Maya Rashish <mrashish@redhat.com>
kubevirt-bot
added
release-note
|
/test pull-containerized-data-importer-e2e-k8s-1.18-nfs |
arnongilboa
suggested changes
Feb 21, 2021
- Avoid a table rather than introducing many items - Mention that scratch space is used as a note, and mention its most painful repercussions. This is probably considered user documentation, and I expect most users won't mind that scratch space is used, so perhaps we can devote slightly less attention to when & why it's used. Signed-off-by: Maya Rashish <mrashish@redhat.com>
Signed-off-by: Maya Rashish <mrashish@redhat.com>
arnongilboa
reviewed
Feb 23, 2021
Signed-off-by: Maya Rashish <mrashish@redhat.com>
Signed-off-by: Maya Rashish <mrashish@redhat.com>
Reduces code duplication Signed-off-by: Maya Rashish <mrashish@redhat.com>
arnongilboa
suggested changes
Feb 25, 2021
This also makes the VDI signature longer. It's pretty long, and we previously only checked the "<<< " parts. This makes us more picky about what's a VDI image, and also makes the magic string meaningful. Signed-off-by: Maya Rashish <mrashish@redhat.com>
|
/lgtm |
arnongilboa
approved these changes
Apr 8, 2021
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/retest |
|
/retest |
|
/test pull-containerized-data-importer-e2e-k8s-1.18-nfs |
|
/retest |
|
/test pull-containerized-data-importer-e2e-k8s-1.18-nfs |
1 similar comment
|
/test pull-containerized-data-importer-e2e-k8s-1.18-nfs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Sometimes images are only available in these formats as file, e.g. Microsoft only offers these formats for Windows VMs.
qemu-img supports them already, we just need to allow it & test it.
It's also a lot simpler to export a file and import it than a warm import from VMware.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Closes #1512
Special notes for your reviewer:
Release note: