Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct singularName for UploadTokenRequests #576

Merged
merged 5 commits into from
Dec 20, 2018
Merged

Conversation

mmazur
Copy link
Contributor

@mmazur mmazur commented Dec 18, 2018

(At least) by convention names and singularNames are all lower case. If
they're not, it might confuse client libraries that don't lowercase
everything proactively. Example:
openshift/openshift-restclient-python#250

Release note:

Correct API discovery for UploadTokenRequests

(At least) by convention names and singularNames are all lower case. If
they're not, it might confuse client libraries that don't lowercase
everything proactively. Example:
openshift/openshift-restclient-python#250
@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically.
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@kubevirt-bot kubevirt-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 18, 2018
@mhenriks
Copy link
Member

ci test please

1 similar comment
@mhenriks
Copy link
Member

ci test please

@mhenriks
Copy link
Member

ci test please

@mhenriks
Copy link
Member

ci test please

@mhenriks mhenriks merged commit 1390ae8 into kubevirt:master Dec 20, 2018
@mhenriks
Copy link
Member

HA apparently I never officially approved this! APPROVED!!
👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants