Lower case URLs #250
Lower case URLs #250
Conversation
openshift-ci-robot
added
the
size/XS
(At least) by convention names and singularNames are all lower case. If they're not, it might confuse client libraries that don't lowercase everything proactively. Example: openshift/openshift-restclient-python#250
|
I've tried looking around for this info and had no luck finding anything. While the API reference is quite explicit in enforcing CamelCase on If you're not sure how to proceed may I suggest limiting this patch to lowercasing only the resource names and shipping 0.8.2/0.9.0 like that? If it turns out somebody hits an issue down the line, you'll get a bug report and can always lowercase more of the url. The issue for downstream here is that any kubevirt/CNV releases in existence have the resource definition for CDI's UploadTokenRequest borked. This is fixed in master, but that's gonna take a while to percolate downstream and in the mean time any code dependent on this library can't use CDI to its full extent. That'd be ok if I had the option of just adding a form of requires: openshift > 0.8.1 somewhere and be sure stuff will work despite CDI's issues, especially considering @pkliczewski FYI last paragraph ⬆️ |
|
Yeah, the lower-case names are purely by convention (https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names), and are not explicitly enforced at the definition level. We'll definitely have some form of this fix included in the next release just to match the |
(At least) by convention names and singularNames are all lower case. If they're not, it might confuse client libraries that don't lowercase everything proactively. Example: openshift/openshift-restclient-python#250
fabianvf
force-pushed
the
lower-case-names
branch
from
ab6f3ee
to
59f8db1
Compare
|
/cherrypick release-0.8 |
|
@fabianvf: once the present PR merges, I will cherry-pick it on top of release-0.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@fabianvf: new pull request created: #254 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mmazur this patch is in v0.8.2 , which is currently building and should be available in pypi later today. |
This matches the behavior of
kubectl, which is able to handle resources that improperly report their name camelCase. More investigation is required to verify that this doesn't break any other behavior (ie, is it safe to always lowercase the full url, or should only name be lowercased?)