New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure volume is removed before returning success #90
Conversation
When removing a volume from a VM, ensure that the volume is actually removed from the VM before returning nil from the ControllerUnpublishVolume function. Added EnsureVolumeRemoved function to virtClient Signed-off-by: Alexander Wels <awels@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidvossel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ensure volume is removed before returning success (kubevirt#90)
When removing a volume from a VM, ensure that the volume is actually removed from the VM before returning nil from the ControllerUnpublishVolume function. Added EnsureVolumeRemoved function to virtClient Signed-off-by: Alexander Wels <awels@redhat.com>
When removing a volume from a VM, ensure that the volume is actually removed from the VM before returning nil from the ControllerUnpublishVolume function. Added EnsureVolumeRemoved function to virtClient Signed-off-by: Alexander Wels <awels@redhat.com>
…-to-release-4.14 [release-4.14] OCPBUGS-19730: Ensure volume is removed before returning success (kubevirt#90)
What this PR does / why we need it:
When removing a volume from a VM, ensure that the volume is actually removed from the VM before returning nil from the ControllerUnpublishVolume function.
Added EnsureVolumeRemoved function to virtClient
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: