OCPBUGS-19720: Ensure volume is removed before returning success (#90) #22
Conversation
When removing a volume from a VM, ensure that the volume is actually removed from the VM before returning nil from the ControllerUnpublishVolume function. Added EnsureVolumeRemoved function to virtClient Signed-off-by: Alexander Wels <awels@redhat.com>
Signed-off-by: Marcin Franczyk <marcin0franczyk@gmail.com>
* Increased timeout of csi-provisioner and csi-attacher. This fixes random failures in the k8s e2e test. Cleaned up some linter issues with using deprecated functions. Ignore server rejection errors from kubevirt addvolume/removevolume and retry them. Signed-off-by: Alexander Wels <awels@redhat.com> * Address review comments. Aligned retry-interval-max between csi-provisioner and csi-attacher Signed-off-by: Alexander Wels <awels@redhat.com> * Use exponetial backoff instead of poll immediate Signed-off-by: Alexander Wels <awels@redhat.com> --------- Signed-off-by: Alexander Wels <awels@redhat.com>
|
/test e2e-kubevirt-aws-csi |
1 similar comment
|
/test e2e-kubevirt-aws-csi |
Signed-off-by: David Vossel <davidvossel@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels, davidvossel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@awels: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherry-pick release-4.15 |
|
/cherry-pick release-4.14 |
|
@awels: new pull request created: #24 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@awels: new pull request created: #25 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
awels
changed the title
|
@awels: Jira Issue OCPBUGS-19720: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-19720 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
When removing a volume from a VM, ensure that the volume is actually removed from the VM before returning nil from the ControllerUnpublishVolume function.
Added EnsureVolumeRemoved function to virtClient
Should fix periodic failure.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: