Adding missing nameserver name to custom A record #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case custom variables are populated, for example:
Then the zone file should contain the below two records (KubeSecondaryDNS nameserver details as defined in external domain server):
This PR adds
ns
prefix inside the A record as shown above.ns
is the default KubeSecondaryDNS nameserver nameThe two records eventually will be converted by the DNS engine into this:
@
that comes in the line before (SOA record) should catch here. And be replaced by$ORIGIN
valuens
prefix but no.
at the end therefore should be completed with $ORIGINSigned-off-by: Diana Teplits dteplits@redhat.com