Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing nameserver name to custom A record #49

Merged
merged 1 commit into from
Dec 18, 2022

Conversation

dteplits
Copy link
Contributor

@dteplits dteplits commented Dec 14, 2022

In case custom variables are populated, for example:

DOMAIN=secondary.io
NAME_SERVER_IP=1.2.3.4

Then the zone file should contain the below two records (KubeSecondaryDNS nameserver details as defined in external domain server):

IN NS ns.vm.secondary.io.
ns IN A 1.2.3.4

This PR adds ns prefix inside the A record as shown above.
ns is the default KubeSecondaryDNS nameserver name

The two records eventually will be converted by the DNS engine into this:

vm.secondary.io. IN NS ns.vm.secondary.io.
ns.vm.secondary.io. IN A 1.2.3.4
  • NS record has no prefix, therefore @ that comes in the line before (SOA record) should catch here. And be replaced by $ORIGIN value
  • A record has ns prefix but no . at the end therefore should be completed with $ORIGIN

Signed-off-by: Diana Teplits dteplits@redhat.com

NONE

Signed-off-by: Diana Teplits <dteplits@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 14, 2022
Copy link
Collaborator

@oshoval oshoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
This PR adds ns prefix inside the IN record as shown above.
you mean IN A right ?

@dteplits
Copy link
Contributor Author

Thanks This PR adds ns prefix inside the IN record as shown above. you mean IN A right ?

I meant A record, fixed it, thanks for noticing

@AlonaKaplan
Copy link
Member

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlonaKaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2022
@kubevirt-bot kubevirt-bot merged commit 5e9280c into kubevirt:main Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants