fix: flaky vm create test #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ksimon1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
0xFelix
reviewed
Feb 15, 2023
ksimon1
force-pushed
the
fix-flaky-vm-create-test
branch
from
d4c8d26
to
b5ef27f
Compare
0xFelix
reviewed
Feb 16, 2023
ksimon1
force-pushed
the
fix-flaky-vm-create-test
branch
from
b5ef27f
to
2fbaf9e
Compare
0xFelix
reviewed
Feb 16, 2023
the test failed a lot of time due to already existing datavolume. This was caused by a string which changed during test run and all test runs under same create mode. This PR refactors the test file and divide all tests into tables. Signed-off-by: Karel Šimon <ksimon@redhat.com>
ksimon1
force-pushed
the
fix-flaky-vm-create-test
branch
from
2fbaf9e
to
bc7fe4f
Compare
|
/lgtm Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fix: flaky vm create test
the test failed a lot of time due to already existing datavolume. This was caused by a string which changed during test run and all test runs had the same string. This PRs moves the test to a
already existing context, where the string is set and do not change during test.
Release note: