[RFE] Additional Tasks #31

atiratree · 2020-12-03T14:54:11Z

Tasks:

atiratree · 2020-12-03T14:55:59Z

configs/virt-customize.yaml

@@ -0,0 +1,2 @@
+task_name: virt-customize


maybe we should name it pvc-virt-customize or disk-virt-customize instead for easier recognition?

hmmm, I like both. Probably disk-... is better since it does not work on any PVC, only on VM disks

atiratree · 2020-12-03T14:58:04Z

tasks/create-vm/manifests/create-vm-from-template.yaml

@@ -39,6 +41,14 @@ spec:
      description: Namespace where to create the VM. (defaults to active namespace)
      default: ""
      type: string
+    - name: sshAuthorizedKeysSecret


I am not sure if we should be adding the authorized keys to the VM only in execute-in-vm task or in create-vm-from-template / virt-customize tasks as well?

Currently it is added to all 3 tasks.

The disadvantage is that the config is quite verbose since we have to specify the users too (possibly propagation policy), but the execute-in-vm task already knows the user.

I would vote to add it only to create-vm-from-template - it makes maintenance of the pipelines easier if one thing is only done one way. Adding it to the other tasks would be useful only if I wanted to have a flow where I take an existing VM and add new keys into it and I dont see that as a valid use case.

atiratree · 2020-12-03T15:05:06Z

tasks/virt-customize/manifests/virt-customize.yaml

+  labels:
+    task.kubevirt.io/type: virt-customize
+    task.kubevirt.io/category: virt-customize
+  name: virt-customize


the disadvantage of this task is that it cannot be run across different namespaces. So it can change only disks in the same namespace as the pipeline is running.

the advantage is that no serviceAccount is needed.

This could be fixed by implementing a CRD and a controller, although that would be a much larger endeavor than implementing a single task. It might be probably better to include this in a CDI which already does similar things.

I dont really see a reason to run the task in a different namespace than the pvc it modifies...

atiratree · 2020-12-03T15:10:07Z

tasks/clone-pvc/README.md

+
+This task clones PersistentVolumeClaims to target PVC by using CDI DataVolumes.
+
+## `clone-pvc`


this might be better to include it as a subtask of create-datavolume task. For example create-datavolume-from-pvc. Thoughts?

the advantages is that there would be less main tasks and we could reuse serviceAccount and roles of create-datavolume

openshift-merge-robot · 2020-12-04T15:09:26Z

@suomiy: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-tests-cluster-scope	`8a9881d`	link	`/test e2e-tests-cluster-scope`
ci/prow/e2e-tests-namespace-scope	`8a9881d`	link	`/test e2e-tests-namespace-scope`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Signed-off-by: suomiy <suomiy@gmail.com>

openshift-ci-robot · 2021-05-06T13:45:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [atiratree]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

atiratree · 2021-05-07T11:46:09Z

/retest

atiratree · 2021-05-07T18:33:58Z

/retest

atiratree · 2021-05-10T07:48:11Z

/retest

kubevirt-bot · 2021-08-08T09:31:45Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

atiratree · 2021-08-10T09:49:19Z

/remove-lifecycle stale

kubevirt-bot · 2021-08-10T13:58:17Z

@atiratree: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot · 2021-11-08T14:13:43Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot · 2021-12-08T15:04:53Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

ksimon1 · 2022-01-03T14:38:05Z

/remove-lifecycle rotten

kubevirt-bot · 2022-04-03T15:14:04Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

atiratree · 2022-04-04T12:13:28Z

most of these tasks have been already implemented

kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 3, 2020

kubevirt-bot requested review from davidvossel and jelkosz December 3, 2020 14:54

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2020

kubevirt-bot added the size/XXL label Dec 3, 2020

atiratree commented Dec 3, 2020

View reviewed changes

atiratree force-pushed the tasksrfes branch from 9a30076 to 8a9881d Compare December 4, 2020 13:45

atiratree force-pushed the tasksrfes branch 2 times, most recently from 21f9956 to e071527 Compare January 8, 2021 14:18

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2021

atiratree force-pushed the tasksrfes branch from e071527 to 32eb9af Compare January 13, 2021 13:30

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2021

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 21, 2021

atiratree force-pushed the tasksrfes branch from 32eb9af to e013a21 Compare January 22, 2021 13:27

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 22, 2021

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2021

atiratree force-pushed the tasksrfes branch from e013a21 to d756e95 Compare February 25, 2021 15:29

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2021

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2021

atiratree mentioned this pull request Mar 11, 2021

add support for including sshPublicKey secret in create-vm-from-template task #66

Closed

atiratree force-pushed the tasksrfes branch from d756e95 to 926affd Compare March 12, 2021 13:27

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2021

atiratree force-pushed the tasksrfes branch from 926affd to 81f5d28 Compare March 12, 2021 13:54

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 6, 2021

atiratree force-pushed the tasksrfes branch from 81f5d28 to c8a9e6c Compare May 4, 2021 00:45

openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2021

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 4, 2021

suomiy added 2 commits May 6, 2021 15:44

[RFE] add clone-pvc task

81b47c2

Signed-off-by: suomiy <suomiy@gmail.com>

[RFE] add clone-template task

c2e03f2

Signed-off-by: suomiy <suomiy@gmail.com>

suomiy added 2 commits May 6, 2021 15:44

[RFE] add modify-vm-template task

193780c

Signed-off-by: suomiy <suomiy@gmail.com>

modify giattributes

e9ce382

Signed-off-by: suomiy <suomiy@gmail.com>

atiratree force-pushed the tasksrfes branch from c8a9e6c to e9ce382 Compare May 6, 2021 13:45

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2021

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2021

openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 10, 2021

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2021

kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 8, 2021

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 8, 2021

openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 8, 2021

kubevirt-bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 8, 2021

openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 3, 2022

kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 3, 2022

atiratree closed this Apr 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RFE] Additional Tasks #31

[RFE] Additional Tasks #31

atiratree commented Dec 3, 2020 •

edited

Loading

atiratree Dec 3, 2020

jelkosz Jan 12, 2021

atiratree Dec 3, 2020

atiratree Dec 3, 2020 •

edited

Loading

jelkosz Dec 4, 2020

atiratree Dec 3, 2020

jelkosz Dec 3, 2020

atiratree Dec 3, 2020

openshift-merge-robot commented Dec 4, 2020

openshift-ci-robot commented May 6, 2021

atiratree commented May 7, 2021

atiratree commented May 7, 2021

atiratree commented May 10, 2021

kubevirt-bot commented Aug 8, 2021

atiratree commented Aug 10, 2021

kubevirt-bot commented Aug 10, 2021

kubevirt-bot commented Nov 8, 2021

kubevirt-bot commented Dec 8, 2021

ksimon1 commented Jan 3, 2022

kubevirt-bot commented Apr 3, 2022

atiratree commented Apr 4, 2022


		This task clones PersistentVolumeClaims to target PVC by using CDI DataVolumes.

		## `clone-pvc`

[RFE] Additional Tasks #31

[RFE] Additional Tasks #31

Conversation

atiratree commented Dec 3, 2020 • edited Loading

atiratree Dec 3, 2020

Choose a reason for hiding this comment

jelkosz Jan 12, 2021

Choose a reason for hiding this comment

atiratree Dec 3, 2020

Choose a reason for hiding this comment

atiratree Dec 3, 2020 • edited Loading

Choose a reason for hiding this comment

jelkosz Dec 4, 2020

Choose a reason for hiding this comment

atiratree Dec 3, 2020

Choose a reason for hiding this comment

jelkosz Dec 3, 2020

Choose a reason for hiding this comment

atiratree Dec 3, 2020

Choose a reason for hiding this comment

openshift-merge-robot commented Dec 4, 2020

openshift-ci-robot commented May 6, 2021

atiratree commented May 7, 2021

atiratree commented May 7, 2021

atiratree commented May 10, 2021

kubevirt-bot commented Aug 8, 2021

atiratree commented Aug 10, 2021

kubevirt-bot commented Aug 10, 2021

kubevirt-bot commented Nov 8, 2021

kubevirt-bot commented Dec 8, 2021

ksimon1 commented Jan 3, 2022

kubevirt-bot commented Apr 3, 2022

atiratree commented Apr 4, 2022

atiratree commented Dec 3, 2020 •

edited

Loading

atiratree Dec 3, 2020 •

edited

Loading