Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Adopters in website #890

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Fix Adopters in website #890

merged 1 commit into from
Jan 26, 2023

Conversation

cwilkers
Copy link
Member

  • Added images for Deckhouse, Killercoda, and Trilio
  • Patched adopters.py script to handle missing images more gracefully
  • Patched adopters.py script to ignore case when searching for images
  • New adopters.py with new images and fixes.

Signed-off-by: cwilkers cwilkers@redhat.com

@cwilkers
Fix Adopters in website
f45bdfb 
- Added images for Deckhouse, Killercoda, and Trilio
- Patched adopters.py script to handle missing images more gracefully
- Patched adopters.py script to ignore case when searching for images
- New adopters.py with new images and fixes.

Signed-off-by: cwilkers <cwilkers@redhat.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jan 25, 2023
@kubevirt-bot kubevirt-bot added kind/website Label for web site management/maintenance/... size/L labels Jan 25, 2023
@cwilkers
Copy link
Member Author

Fixes #889

aburdenthehand
aburdenthehand approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@aburdenthehand aburdenthehand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
I can't speak for the python updates but I can confirm that the page builds locally with all images as expected. Thanks Chandler!

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2023
@cwilkers
Copy link
Member Author

Thanks @aburdenthehand , I'll go ahead with the approval.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cwilkers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2023
@kubevirt-bot kubevirt-bot merged commit bdaee85 into kubevirt:main Jan 26, 2023
@cwilkers cwilkers mentioned this pull request Feb 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aburdenthehand aburdenthehand aburdenthehand approved these changes

@mazzystr mazzystr Awaiting requested review from mazzystr

@jobbler jobbler Awaiting requested review from jobbler

Assignees

@aburdenthehand aburdenthehand

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/website Label for web site management/maintenance/... lgtm Indicates that a PR is ready to be merged. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cwilkers @kubevirt-bot @aburdenthehand