Skip to content

Commit

Permalink
Add separation between registry push and publish
Browse files Browse the repository at this point in the history
 * "publish" includes dirty checks before pushing
 * "push" pushes also with dirty binaries
  • Loading branch information
rmohr committed Jun 25, 2018
1 parent 1074af7 commit f31b704
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ deps-update:
docker: build
hack/build-docker.sh build ${WHAT}

push: docker
hack/build-docker.sh push ${WHAT}

publish: docker verify-build
hack/build-docker.sh push ${WHAT}

Expand Down
2 changes: 1 addition & 1 deletion cluster/ephemeral-provider-common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ function build() {

# Build everyting and publish it
${KUBEVIRT_PATH}hack/dockerized "DOCKER_TAG=${DOCKER_TAG} KUBEVIRT_PROVIDER=${KUBEVIRT_PROVIDER} ./hack/build-manifests.sh"
make build docker publish
make push

# Make sure that all nodes use the newest images
container=""
Expand Down

0 comments on commit f31b704

Please sign in to comment.