Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[outreachy] [good-first-issue] Refactor tests #6495

Closed
vatsalparekh opened this issue Oct 1, 2021 · 9 comments
Closed

[outreachy] [good-first-issue] Refactor tests #6495

vatsalparekh opened this issue Oct 1, 2021 · 9 comments
Assignees
Labels
good-first-issue Identifies an issue that has been specifically created or selected for first-time contributors. kind/enhancement lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@vatsalparekh
Copy link
Contributor

vatsalparekh commented Oct 1, 2021

Is this a BUG REPORT or FEATURE REQUEST?:
/kind enhancement

What happened:
Sonarcloud has many refactoring suggestions to reduce code complexity for the tests directory here
What you expected to happen:

Refactor and break the code into more readable and manageable blocks

@phoracek phoracek added the good-first-issue Identifies an issue that has been specifically created or selected for first-time contributors. label Oct 1, 2021
@odra
Copy link

odra commented Oct 6, 2021

I would like to work on this issue if it is free :-)

@vatsalparekh
Copy link
Contributor Author

@odra feel free to assign this to yourself

@odra
Copy link

odra commented Oct 6, 2021

I don' t think I have the perms to do so :)

@xpivarc
Copy link
Member

xpivarc commented Oct 6, 2021

/assign @odra

@odra
Copy link

odra commented Oct 6, 2021

thanks!

@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2022
@kubevirt-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubevirt-bot kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 3, 2022
@kubevirt-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@kubevirt-bot
Copy link
Contributor

@kubevirt-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Identifies an issue that has been specifically created or selected for first-time contributors. kind/enhancement lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants