[WIP] test refactoring #6544

odra · 2021-10-07T15:15:38Z

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #6495

Special notes for your reviewer:

WIP - sending a partial PR to test sonarcloud report.

I will update this section as the PR work evolves.

Release note:

NONE

kubevirt-bot · 2021-10-07T15:15:53Z

Hi @odra. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot · 2021-10-07T15:20:18Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign enp0s3 after the PR has been reviewed.
You can assign the PR to them by writing /assign @enp0s3 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vatsalparekh · 2021-10-08T07:29:24Z

/ok-to-test

xpivarc

Thanks for your contribution.

There is one compilation problem.
Generally, it's best if you run make && make test before submitting PR to avoid these small issues.

xpivarc · 2021-10-20T08:52:17Z

tests/io_utils.go

@@ -38,6 +38,20 @@ import (
 	"kubevirt.io/kubevirt/tests/util"
 )

+
+func gen_chroot_args(args...string) []string {


Please use camelCase for consistency.

I guess this can be named better. What it does is it will execute the virt-chroot binary. It will then switch to the mount namespace of the host(PID 1) and execute the given command in this "context".

I renamed it to "createVirtChrootCMD" since it just creates the command string and does not really execute anything.

Also, do you think that function should be moved to tests/utils.go?

Yes, it doesn't execute the actual command. It just creates a command that does what I described. createVirtChrootCMD doesn't tell me much except we will execute virt-chroot. But virt-chroot has a lot of usecases.

I don't think it's necessary to move it as it is only used in this file.

xpivarc · 2021-10-29T08:07:55Z

tests/job.go

 		for _, c := range job.Status.Conditions {
-			switch c.Type {


Why was this changed?

Signed-off-by: Leonardo Rossetti <lrossett@redhat.com>

kubevirt-bot · 2021-12-12T23:38:20Z

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

76d923c test/io_utils.go refactor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kubevirt-bot · 2021-12-12T23:46:38Z

@odra: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kubevirt-bot · 2021-12-30T14:25:30Z

@odra: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot · 2022-03-30T15:02:05Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot · 2022-04-29T15:08:15Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

kubevirt-bot · 2022-05-29T15:29:43Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

kubevirt-bot · 2022-05-29T15:29:47Z

@kubevirt-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot requested review from ILpinto and kbidarkar October 7, 2021 15:20

kubevirt-bot assigned vatsalparekh Oct 8, 2021

kubevirt-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 8, 2021

odra force-pushed the issue_6594-refactor-tests branch from e663f2f to f7d43bc Compare October 9, 2021 18:15

xpivarc requested changes Oct 20, 2021

View reviewed changes

kubevirt-bot assigned xpivarc Oct 20, 2021

odra force-pushed the issue_6594-refactor-tests branch 2 times, most recently from 3cae533 to 3b81df7 Compare October 20, 2021 13:57

kubevirt-bot added size/M and removed size/S labels Oct 20, 2021

xpivarc reviewed Oct 29, 2021

View reviewed changes

tests/job.go

for _, c := range job.Status.Conditions {

switch c.Type {

Copy link

Member

xpivarc Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed?

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2021

odra added 3 commits December 12, 2021 18:42

test/io_utils.go refactor

76d923c

job.go refactor

6653f6d

Signed-off-by: Leonardo Rossetti <lrossett@redhat.com>

refactor test/utils.go

50d0a88

Signed-off-by: Leonardo Rossetti <lrossett@redhat.com>

odra force-pushed the issue_6594-refactor-tests branch from 55e2abd to 50d0a88 Compare December 12, 2021 23:38

kubevirt-bot added size/L and removed size/M needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 12, 2021

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 30, 2021

kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 30, 2022

kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 29, 2022

kubevirt-bot closed this May 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] test refactoring #6544

[WIP] test refactoring #6544

odra commented Oct 7, 2021 •

edited

kubevirt-bot commented Oct 7, 2021

kubevirt-bot commented Oct 7, 2021

vatsalparekh commented Oct 8, 2021

xpivarc left a comment

xpivarc Oct 20, 2021

xpivarc Oct 20, 2021

odra Oct 20, 2021

odra Oct 20, 2021

xpivarc Oct 29, 2021

xpivarc Oct 29, 2021

kubevirt-bot commented Dec 12, 2021

kubevirt-bot commented Dec 12, 2021

kubevirt-bot commented Dec 30, 2021

kubevirt-bot commented Mar 30, 2022

kubevirt-bot commented Apr 29, 2022

kubevirt-bot commented May 29, 2022

kubevirt-bot commented May 29, 2022

[WIP] test refactoring #6544

[WIP] test refactoring #6544

Conversation

odra commented Oct 7, 2021 • edited

kubevirt-bot commented Oct 7, 2021

kubevirt-bot commented Oct 7, 2021

vatsalparekh commented Oct 8, 2021

xpivarc left a comment

Choose a reason for hiding this comment

xpivarc Oct 20, 2021

Choose a reason for hiding this comment

xpivarc Oct 20, 2021

Choose a reason for hiding this comment

odra Oct 20, 2021

Choose a reason for hiding this comment

odra Oct 20, 2021

Choose a reason for hiding this comment

xpivarc Oct 29, 2021

Choose a reason for hiding this comment

xpivarc Oct 29, 2021

Choose a reason for hiding this comment

kubevirt-bot commented Dec 12, 2021

kubevirt-bot commented Dec 12, 2021

kubevirt-bot commented Dec 30, 2021

kubevirt-bot commented Mar 30, 2022

kubevirt-bot commented Apr 29, 2022

kubevirt-bot commented May 29, 2022

kubevirt-bot commented May 29, 2022

odra commented Oct 7, 2021 •

edited