Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VM status when a VM dies or is shutdown #75

Closed
3 tasks
rmohr opened this issue Feb 2, 2017 · 1 comment
Closed
3 tasks

Update VM status when a VM dies or is shutdown #75

rmohr opened this issue Feb 2, 2017 · 1 comment
Labels
help-wanted kind/enhancement

Comments

@rmohr
Copy link
Member

rmohr commented Feb 2, 2017 •
edited

virt-handler gets an event from libvirt whenever a Domain is shutdown or killed in domain.go.

If a Domain is shutdown, the VM should enter the phase Succeeded. If a VM crashed or was killed, it should enter the phase Failed. The field reflecting this is VMSpec.Status.Phase. In the watch loop we need to check for the reason of the shutdown and update the Phase.

  • Update the Phase on the VM via the restclient according to the shutdown reason.
  • Write functional tests in tests/vm_lifecycle.go
  • If a Domain is stopped or crahes, virt-handler should not try to restart it
@rmohr rmohr changed the title Update VM status when a VM dies or is shut down Update VM status when a VM dies or is shutdown Feb 2, 2017
@rmohr rmohr mentioned this issue Feb 2, 2017
Closed
@mpolednik
Copy link
Contributor

Started working on this, PR coming asap.

@mpolednik mpolednik mentioned this issue Mar 16, 2017
Merged
@mpolednik mpolednik mentioned this issue Mar 27, 2017
Closed
rmohr added a commit that referenced this issue Mar 28, 2017
@rmohr
Merge pull request #149 from mpolednik/phases
301b847 
update VM phase by checking domain status and reason, fixes #75
kubevirt-bot pushed a commit to kubevirt-bot/kubevirt that referenced this issue Nov 6, 2020
@copejon
Merge pull request kubevirt#75 from copejon/fix-datastream-bug
29cc4a1 
fixed bug in multistreamreader
kubevirt-bot pushed a commit to kubevirt-bot/kubevirt that referenced this issue Dec 7, 2021
enable audit log for os-3.11 (kubevirt#75)
ba676dd 
* enable audit log for os-3.11

Signed-off-by: Marcin Franczyk <mfranczy@redhat.com>

* use ansible-2.7.9-1 for os-3.11

* increase VM memory for os provisioners

* Update README with new hashes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help-wanted kind/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpolednik @rmohr