Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libvirt ListWatch should add reason to virtwrap.DomainStatus #82

Closed
rmohr opened this issue Feb 2, 2017 · 1 comment · Fixed by #83
Closed

Libvirt ListWatch should add reason to virtwrap.DomainStatus #82

rmohr opened this issue Feb 2, 2017 · 1 comment · Fixed by #83
Labels
help-wanted kind/enhancement

Comments

@rmohr
Copy link
Member

rmohr commented Feb 2, 2017 •
edited

Currently we are only collecting the Domain state and store it in virtwrap.DomainStatus.

We should also add the reason why the state was entered by the VM. Of special interest are the states

virDomainShutdownReason and virDomainShutoffReason.

They should be translated to a go constant and stored in a new field virtwrap.DomainStatus.Reason.

Currently the state is determined in cache.go#L36.

This is a prerequisite to #75.
@mpolednik
Copy link
Contributor

On it.

@mpolednik mpolednik mentioned this issue Feb 2, 2017
Merged
@rmohr rmohr closed this as completed in #83 Mar 3, 2017
mmazur pushed a commit to mmazur/kubevirt that referenced this issue May 29, 2019
Revert "Enable PodSecurityPolicies for k8s clusters (kubevirt#81)" (k…
58e7c78 
…ubevirt#82)

This reverts commit ad552d5.
kubevirt-bot pushed a commit to kubevirt-bot/kubevirt that referenced this issue Nov 6, 2020
@jeffvance
Merge pull request kubevirt#82 from jeffvance/cdi-ns
b335286 
support multiple namespaces
@KinglyWayne KinglyWayne mentioned this issue May 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help-wanted kind/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

extend Domain to include Shut{off,down} reason mpolednik/kubevirt
2 participants
@mpolednik @rmohr