[virt-operator] cope with misscheduled virt-handler pods #10254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note
rmohr
force-pushed
the
deploymentinprogress
branch
from
4732368
to
9c37bdc
Compare
|
/cc @acardace |
rmohr
force-pushed
the
deploymentinprogress
branch
from
9c37bdc
to
9491090
Compare
Applying a custom `NoSchedule` taint to a nod will flip the `Available`
condition of KubeVirt to `False`:
```
- lastProbeTime: "2023-08-07T14:15:43Z"
lastTransitionTime: "2023-08-07T14:15:43Z"
message: Deploying version devel with registry registry:5000/kubevirt
reason: DeploymentInProgress
status: "False"
type: Available
```
This will only resolve back to `True` if the pod gets manually evicted,
or if the daemonset gets updated.
The background is, that we will see more up-to-date virt-handler pods in
ready state than we actually want.
Relax the readiness check slightly by counting misscheduled but
up-to-date and ready virt-handlers as something which does not trigger a
`DeploymentInProgress` state.
Signed-off-by: Roman Mohr <rmohr@google.com>
rmohr
force-pushed
the
deploymentinprogress
branch
from
9491090
to
12bdb2e
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acardace The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
@acardace any chance you could also review the change? |
|
/lgtm |
|
/retest-required |
|
/retest-required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Applying a custom
NoScheduletaint to a nod will flip theAvailablecondition of KubeVirt toFalse:This will only resolve back to
Trueif the pod gets manually evicted, or if the daemonset gets updated.The background is, that we will see more up-to-date virt-handler pods in ready state than we actually want.
Relax the readiness check slightly by counting misscheduled but up-to-date and ready virt-handlers as something which does not trigger a
DeploymentInProgressstate.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: