Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[virt-operator] cope with misscheduled virt-handler pods #10254

Merged
merged 1 commit into from
Aug 10, 2023
Merged

[virt-operator] cope with misscheduled virt-handler pods #10254

merged 1 commit into from
Aug 10, 2023

Commits on Aug 7, 2023

  1. [virt-operator] cope with misscheduled virt-handler pods 

    Applying a custom `NoSchedule` taint to a nod will flip the `Available`
condition of KubeVirt to `False`:

```
  - lastProbeTime: "2023-08-07T14:15:43Z"
    lastTransitionTime: "2023-08-07T14:15:43Z"
    message: Deploying version devel with registry registry:5000/kubevirt
    reason: DeploymentInProgress
    status: "False"
    type: Available
```

This will only resolve back to `True` if the pod gets manually evicted,
or if the daemonset gets updated.

The background is, that we will see more up-to-date virt-handler pods in
ready state than we actually want.

Relax the readiness check slightly by counting misscheduled but
up-to-date and ready virt-handlers as something which does not trigger a
`DeploymentInProgress` state.

Signed-off-by: Roman Mohr <rmohr@google.com>
    @rmohr
    rmohr committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    12bdb2e View commit details
    Browse the repository at this point in the history