Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.0] update metrics names #10323

Closed
wants to merge 4 commits into from
Closed

[release-1.0] update metrics names #10323

wants to merge 4 commits into from

Conversation

avlitman
Copy link
Contributor

@avlitman avlitman commented Aug 22, 2023 •
edited

Aviv Litman added 3 commits August 22, 2023 14:04
[release-1.0] Expose kubevirt_vmi_vcpu_delay_seconds_total metric
3f59c52 
This is a manual cherry-pic of kubevirt#10107

Signed-off-by: Aviv Litman <alitman@alitman-thinkpadp1gen4i.tlv.csb>
[release-1.0] Add help text to the migration phase transition time me…
ed1030f 
…tric

This is a manual cherry-pick of kubevirt#9787

Signed-off-by: Aviv Litman <alitman@alitman-thinkpadp1gen4i.tlv.csb>
[release-1.0] Update metric names to fit metrics naming conventions
23b3e7a 
This is a manual cherry-pick of https://github.com/kubevirt/kubevirt/pull/9821/files#top

Signed-off-by: Aviv Litman <alitman@alitman-thinkpadp1gen4i.tlv.csb>
@kubevirt-bot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 22, 2023
@kubevirt-bot kubevirt-bot added area/monitoring size/L needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 22, 2023
@kubevirt-bot
Copy link
Contributor

Hi @avlitman. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@avlitman
Copy link
Contributor Author

/hold since blocked by #10322

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2023
@avlitman avlitman mentioned this pull request Aug 22, 2023
Merged
enp0s3
enp0s3 suggested changes Aug 27, 2023
View reviewed changes
Copy link
Contributor

@enp0s3 enp0s3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avlitman Hi. Please add the prefix [release-1.0] in the PR title

@enp0s3
Copy link
Contributor

enp0s3 commented Aug 27, 2023

@sradco @machacekondra @avlitman Hi. Since these are breaking changes, I would not backport them. Its identical to a situation where some bug requires API change, I don't remember such cases.

@avlitman avlitman changed the title R1.0 update metrics names [release-1.0] update metrics names Aug 27, 2023
[release-1.0] Reference changed without changing the definition
2c63a86 
This is a manual cherry-pick of kubevirt#10322

Signed-off-by: Aviv Litman <alitman@alitman-thinkpadp1gen4i.tlv.csb>
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from enp0s3. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@avlitman
Copy link
Contributor Author

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2023
@avlitman
Copy link
Contributor Author

As agreed with @enp0s3 and @kmajcher-rh we decided to postpone these changes to 4.15 therefor I'm closing this pr.

@avlitman avlitman closed this Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enp0s3 enp0s3 enp0s3 requested changes

@kbidarkar kbidarkar Awaiting requested review from kbidarkar

@marceloamaral marceloamaral Awaiting requested review from marceloamaral

@rthallisey rthallisey Awaiting requested review from rthallisey

Assignees

@enp0s3 enp0s3

Labels
area/monitoring dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@avlitman @kubevirt-bot @enp0s3