Update metric names to fit metrics naming conventions #9821

sradco · 2023-05-30T10:40:26Z

Signed-off-by: Shirly Radco sradco@redhat.com

What this PR does / why we need it:
This PR updated metrics names to meet the metrics naming conventions.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #9714

Special notes for your reviewer:

Release note:

Deprecation notice for the metrics listed in the PR. Please update your systems to use the new metrics names.

|kubevirt_migrate_vmi_failed | kubevirt_vmi_migrations_failed|
|kubevirt_migrate_vmi_succeeded | kubevirt_vmi_migrations_succeeded|
|kubevirt_migrate_vmi_pending_count | kubevirt_vmi_migrations_pending|
|kubevirt_migrate_vmi_running_count | kubevirt_vmi_migrations_running|
|kubevirt_migrate_vmi_scheduling_count | kubevirt_vmi_migrations_scheduling|
|kubevirt_vmi_filesystem_capacity_bytes_total | kubevirt_vmi_filesystem_capacity_bytes|
|kubevirt_vmi_memory_domain_bytes_total | kubevirt_vmi_memory_domain_bytes|
|kubevirt_vmi_memory_pgmajfault | kubevirt_vmi_memory_pgmajfault_total|
|kubevirt_vmi_memory_pgminfault | kubevirt_vmi_memory_pgminfault_total|
|kubevirt_vmi_memory_swap_in_traffic_bytes_total | kubevirt_vmi_memory_swap_in_traffic_bytes|
|kubevirt_vmi_memory_swap_out_traffic_bytes_total | kubevirt_vmi_memory_swap_out_traffic_bytes|
|kubevirt_vmi_outdated_count | kubevirt_vmi_number_of_outdated|
|kubevirt_vmi_storage_flush_times_ms_total | kubevirt_vmi_storage_flush_times_seconds_total|
|kubevirt_vmi_storage_read_times_ms_total | kubevirt_vmi_storage_read_times_seconds_total|
|kubevirt_vmi_storage_write_times_ms_total | kubevirt_vmi_storage_write_times_seconds_total|
|kubevirt_vmi_vcpu_seconds | kubevirt_vmi_vcpu_seconds_total|
|kubevirt_vmi_vcpu_wait_seconds | kubevirt_vmi_vcpu_wait_seconds_total|
|kubevirt_vmsnapshot_disks_restored_from_source_total | kubevirt_vmsnapshot_disks_restored_from_source|
|kubevirt_allocatable_nodes_count | kubevirt_allocatable_nodes|
|kubevirt_kvm_available_nodes_count | kubevirt_nodes_with_kvm|
|kubevirt_virt_api_up_total | kubevirt_virt_api_up|
|kubevirt_virt_controller_ready_total | kubevirt_virt_controller_ready|
|kubevirt_virt_controller_ready | kubevirt_virt_controller_ready_status|
|kubevirt_virt_controller_up_total | kubevirt_virt_controller_up|
|kubevirt_virt_handler_up_total | kubevirt_virt_handler_up|
|kubevirt_virt_operator_leading_total | kubevirt_virt_operator_leading|
|kubevirt_virt_operator_leading | kubevirt_virt_operator_leading_status|
|kubevirt_virt_operator_ready_total | kubevirt_virt_operator_ready|
|kubevirt_virt_operator_ready | kubevirt_virt_operator_ready_status|
|kubevirt_virt_operator_up_total | kubevirt_virt_operator_up|

sradco · 2023-05-30T10:52:39Z

@machadovilaca @assafad @avlitman Please review

sradco · 2023-05-30T12:36:46Z

/retest-required

sradco · 2023-05-30T14:23:33Z

/retest-required

avlitman · 2023-05-30T16:32:37Z

Hi @sradco I'm not sure how it happened since I rebased few times before running the linter but my fork was not up to date so I missed some new metrics that also failing the linter.
The linter output after this changes is:
kubevirt_allocatable_nodes_count: non-histogram and non-summary metrics should not have "_count" suffix
kubevirt_kvm_available_nodes_count: non-histogram and non-summary metrics should not have "_count" suffix
kubevirt_virt_api_up_total: non-counter metrics should not have "_total" suffix
kubevirt_virt_controller_ready_total: non-counter metrics should not have "_total" suffix
kubevirt_virt_controller_up_total: non-counter metrics should not have "_total" suffix
kubevirt_virt_handler_up_total: non-counter metrics should not have "_total" suffix
kubevirt_virt_operator_leading_total: non-counter metrics should not have "_total" suffix
kubevirt_virt_operator_ready_total: non-counter metrics should not have "_total" suffix
kubevirt_virt_operator_up_total: non-counter metrics should not have "_total" suffix
kubevirt_vmi_phase_count: non-histogram and non-summary metrics should not have "_count" suffix

so needs to update this names as well:
kubevirt_allocatable_nodes_count: kubevirt_number_of_allocatable_nodes
kubevirt_kvm_available_nodes_count: kubevirt_kvm_number_of_available_nodes
not sure about this names all are Gauge's type so can't end with count/total:
kubevirt_virt_api_up_total
kubevirt_virt_controller_ready_total
kubevirt_virt_controller_up_total
kubevirt_virt_handler_up_total
kubevirt_virt_operator_leading_total
kubevirt_virt_operator_ready_total
kubevirt_virt_operator_up_total
kubevirt_vmi_phase_count: kubevirt_vmi_number_of_phases or kubevirt_vmi_number_of_phase

sradco · 2023-06-01T11:27:49Z

@avlitman please open the new metrics names that needs update in a separate issue, for an easier review.
Thank you.

avlitman · 2023-06-01T12:15:43Z

@avlitman please open the new metrics names that needs update in a separate issue, for an easier review. Thank you.

New issue: #9836
New bug: https://bugzilla.redhat.com/show_bug.cgi?id=2211671

machadovilaca · 2023-06-07T14:25:22Z

pkg/virt-operator/resource/generate/components/prometheus.go

+			},
+			MType:       prometheusv1.MetricTypeGauge,
+			Description: "Total VM filesystem capacity in bytes. [Deprecated]",
+		},
+		{
+			Rule: v1.Rule{
+				Record: "kubevirt_vmi_memory_domain_bytes_total",
+				Expr:   intstr.FromString("kubevirt_vmi_memory_domain_bytes"),
+			},
+			MType:       prometheusv1.MetricTypeGauge,
+			Description: "The amount of memory in bytes allocated to the domain. The `memory` value in domain xml file. [Deprecated]",
+		},
+		{
+			Rule: v1.Rule{
+				Record: "kubevirt_vmi_memory_pgmajfault",
+				Expr:   intstr.FromString("kubevirt_vmi_memory_pgmajfault_total"),
+			},
+			MType:       prometheusv1.MetricTypeCounter,
+			Description: "The number of page faults when disk IO was required. Page faults occur when a process makes a valid access to virtual memory that is not available. When servicing the page fault, if disk IO is required, it is considered as major fault. [Deprecated]",
+		},
+		{
+			Rule: v1.Rule{
+				Record: "kubevirt_vmi_memory_pgminfault",
+				Expr:   intstr.FromString("kubevirt_vmi_memory_pgminfault_total"),
+			},
+			MType:       prometheusv1.MetricTypeCounter,
+			Description: "The number of other page faults, when disk IO was not required. Page faults occur when a process makes a valid access to virtual memory that is not available. When servicing the page fault, if disk IO is NOT required, it is considered as minor fault. [Deprecated]",
+		},
+		{
+			Rule: v1.Rule{
+				Record: "kubevirt_vmi_memory_swap_in_traffic_bytes_total",
+				Expr:   intstr.FromString("kubevirt_vmi_memory_swap_in_traffic_bytes"),
+			},
+			MType:       prometheusv1.MetricTypeGauge,
+			Description: "The total amount of data read from swap space of the guest in bytes. [Deprecated]",
+		},
+		{
+			Rule: v1.Rule{
+				Record: "kubevirt_vmi_memory_swap_out_traffic_bytes_total",
+				Expr:   intstr.FromString("kubevirt_vmi_memory_swap_out_traffic_bytes"),
+			},
+			MType:       prometheusv1.MetricTypeGauge,
+			Description: "The total amount of memory written out to swap space of the guest in bytes. [Deprecated]",
+		},
+		{
+			Rule: v1.Rule{
+				Record: "kubevirt_vmi_outdated_count",
+				Expr:   intstr.FromString("kubevirt_vmi_number_of_outdated"),
+			},
+			MType:       prometheusv1.MetricTypeGauge,
+			Description: "Indication for the total number of VirtualMachineInstance workloads that are not running within the most up-to-date version of the virt-launcher environment. [Deprecated]",
+		},
+		{
+			Rule: v1.Rule{
+				Record: "kubevirt_vmi_storage_flush_times_ms_total",
+				Expr:   intstr.FromString("kubevirt_vmi_storage_flush_times_seconds_total * 1000"),
+			},
+			MType:       prometheusv1.MetricTypeCounter,
+			Description: "Total time (ms) spent on cache flushing. [Deprecated]",
+		},
+		{
+			Rule: v1.Rule{
+				Record: "kubevirt_vmi_storage_read_times_ms_total",
+				Expr:   intstr.FromString("kubevirt_vmi_storage_read_times_ms_total * 1000"),
+			},
+			MType:       prometheusv1.MetricTypeCounter,
+			Description: "Total time (ms) spent on read operations. [Deprecated]",
+		},
+		{
+			Rule: v1.Rule{
+				Record: "kubevirt_vmi_storage_write_times_ms_total",
+				Expr:   intstr.FromString("kubevirt_vmi_storage_write_times_seconds_total * 1000"),
+			},
+			MType:       prometheusv1.MetricTypeCounter,
+			Description: "Total time (ms) spent on write operations. [Deprecated]",
+		},
+		{
+			Rule: v1.Rule{
+				Record: "kubevirt_vmi_vcpu_seconds",
+				Expr:   intstr.FromString("kubevirt_vmi_vcpu_seconds_total"),
+			},
+			MType:       prometheusv1.MetricTypeCounter,
+			Description: "Total amount of time spent in each state by each vcpu (cpu_time excluding hypervisor time). Where `id` is the vcpu identifier and `state` can be one of the following: [`OFFLINE`, `RUNNING`, `BLOCKED`]. [Deprecated]",
+		},
+		{
+			Rule: v1.Rule{
+				Record: "kubevirt_vmi_vcpu_wait_seconds",
+				Expr:   intstr.FromString("kubevirt_vmi_vcpu_wait_seconds_total"),
+			},
+			MType:       prometheusv1.MetricTypeCounter,
+			Description: "Amount of time spent by each vcpu while waiting on I/O. [Deprecated]",
+		},
+		{
+			Rule: v1.Rule{
+				Record: "kubevirt_vmsnapshot_disks_restored_from_source_total",
+				Expr:   intstr.FromString("kubevirt_vmsnapshot_disks_restored_from_source"),
+			},
+			MType:       prometheusv1.MetricTypeGauge,
+			Description: "Returns the total number of virtual machine disks restored from the source virtual machine. [Deprecated]",
+		},


maybe can we move these to a separate function, maybe GetDeprecatedRecordingRules, to have a clear distinction for the deprecated items?

maybe even somehow include the last version they were not deprecated -> GetDeprecatedRecordingRulesAfterRelease59

that would make it easier to track the metrics to completely remove after 2 minor releases or something, and it would be very simple to remove them

I updated the PR so that the new metric names will be the recording rules and in 2 versions we would replace the metric names and remove the recording rules.
I did this since the help text is not visible for recording rule, only for metrics.

sradco · 2023-06-12T20:47:49Z

/retest-required

sradco · 2023-06-14T07:29:29Z

/retest-required

sradco · 2023-06-14T09:31:54Z

/retest-required

pull-kubevirt-code-lint isn't failing on something that is related to this PR.

sradco · 2023-06-14T10:09:32Z

@machadovilaca @vladikr @lyarwood Please review.

lyarwood · 2023-06-14T17:11:35Z

I don't really have any comments on the new names but I've got a few nits below regarding the PR description and release note:

What this PR does / why we need it: This PR updated metrics names to meet the metrics naming conventions. The old metrics names will still be available in order to allow the users to update their dashboards, but will be deprecated in a few months.

I think you mean removed in a future release instead of deprecated right?

Release note:

Deprecation notice for the metrics listed in the PR. They will be removed in the next releases. Please update your systems to use the new metrics names.

Can we list the deprecated metrics in the docs somewhere and link to that here? Referencing the PR isn't helpful IMHO.

Also as above I'd change this to They will be removed in a future release.

Updated kubevirt_vmi_vcpu_seconds to kubevirt_vmi_vcpu_seconds_total based on PR kubevirt/kubevirt#9821 Signed-off-by: Shirly Radco <sradco@redhat.com>

avlitman · 2023-08-17T06:56:37Z

/retest-required

sradco · 2023-08-17T07:34:21Z

@enp0s3 @avlitman, can you please cherrypick this PR to 4.14 after it is merged?

avlitman · 2023-08-17T08:07:29Z

/retest-required

enp0s3 · 2023-08-17T10:24:24Z

/retest-required

kubevirt-bot · 2023-08-17T12:13:01Z

@sradco: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubevirt-check-tests-for-flakes	`dfdd479`	link	false	`/test pull-kubevirt-check-tests-for-flakes`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

enp0s3 · 2023-08-17T13:14:07Z

@akalenyu @awels @ShellyKa13 Hey! can you please keep me honest about the sig-storage being flaky on this PR? I saw it fail 4 times in a row, each time on a different test.

awels · 2023-08-17T13:30:53Z

Not aware of any particular flaky test in the storage lane.

avlitman · 2023-08-17T13:58:21Z

/retest-required

enp0s3 · 2023-08-17T13:59:18Z

@avlitman Lets wait with the retest, I will either override it or there is a real issue, one way or another we need assistance from the storage folks.

akalenyu · 2023-08-17T15:34:36Z

@akalenyu @awels @ShellyKa13 Hey! can you please keep me honest about the sig-storage being flaky on this PR? I saw it fail 4 times in a row, each time on a different test.

So analyzing the failing lanes:
one of them fails due to cluster-down err:

09:15:10: Error response from daemon: getting graph driver info "3d21579dd692968d8dcfea11258427da8fa537f7255f519fbbfe17feb0e8116b": readlink /var/lib/containers/storage/overlay/l/WTISSZB7Y4M2FBXJNTY2VDHGQV: no such file or directory
make: *** [Makefile:153: cluster-down] Error 1

The other 3 runs have real flakes:
NFS pod test

This other flake
Seems like the importer pod's init container is failing to start with no interesting events

And last one is this
Not sure how we get 502, usually that would happen a lot with kubectl port forward, but we're not doing that anymore
and using a NodePort instead

kubevirt-commenter-bot · 2023-08-17T19:15:00Z

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

sradco · 2023-08-19T12:55:22Z

@avlitman @enp0s3 please backport this PR to 4.14

avlitman · 2023-08-20T10:29:58Z

@enp0s3 Should I cherry-pick for both 0.59 and 1.0 like in this latest Joao's re-naming metrics pr: #10138?

enp0s3 · 2023-08-21T06:08:25Z

/cherry-pick release-1.0

kubevirt-bot · 2023-08-21T06:09:02Z

@enp0s3: #9821 failed to apply on top of branch "release-1.0":

Applying: Update metric names to fit metrics naming conventions
Using index info to reconstruct a base tree...
M	docs/metrics.md
M	pkg/monitoring/domainstats/prometheus/prometheus.go
M	pkg/monitoring/domainstats/prometheus/prometheus_test.go
M	pkg/virt-operator/application.go
M	pkg/virt-operator/resource/generate/components/prometheus.go
A	tests/infrastructure/prometheus.go
M	tools/doc-generator/doc-generator.go
M	tools/prom-metrics-collector/metrics_collector.go
Falling back to patching base and 3-way merge...
Auto-merging tools/prom-metrics-collector/metrics_collector.go
CONFLICT (content): Merge conflict in tools/prom-metrics-collector/metrics_collector.go
Auto-merging tools/doc-generator/doc-generator.go
CONFLICT (content): Merge conflict in tools/doc-generator/doc-generator.go
CONFLICT (modify/delete): tests/infrastructure/prometheus.go deleted in HEAD and modified in Update metric names to fit metrics naming conventions. Version Update metric names to fit metrics naming conventions of tests/infrastructure/prometheus.go left in tree.
Auto-merging pkg/virt-operator/resource/generate/components/prometheus.go
Auto-merging pkg/virt-operator/application.go
Auto-merging pkg/monitoring/domainstats/prometheus/prometheus_test.go
Auto-merging pkg/monitoring/domainstats/prometheus/prometheus.go
CONFLICT (content): Merge conflict in pkg/monitoring/domainstats/prometheus/prometheus.go
Auto-merging docs/metrics.md
CONFLICT (content): Merge conflict in docs/metrics.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update metric names to fit metrics naming conventions
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

enp0s3 · 2023-08-21T06:31:39Z

@avlitman @assafad @machadovilaca Hi, please create a manual backport PR.

Updated kubevirt metrics names: kubevirt_vmi_vcpu_wait_seconds to kubevirt_vmi_vcpu_wait_seconds_total kubevirt_vmsnapshot_disks_restored_from_source_total to kubevirt_vmsnapshot_disks_restored_from_source kubevirt_vmi_memory_swap_in_traffic_bytes_total to kubevirt_vmi_memory_swap_in_traffic_bytes kubevirt_vmi_memory_swap_out_traffic_bytes_total to kubevirt_vmi_memory_swap_out_traffic_bytes Based on PR kubevirt/kubevirt#9821 Signed-off-by: Shirly Radco <sradco@redhat.com>

Updated live migration metrics names kubevirt_migrate_vmi_pending_count to kubevirt_vmi_migrations_pending kubevirt_migrate_vmi_scheduling_count to kubevirt_vmi_migrations_scheduling kubevirt_migrate_vmi_running_count to kubevirt_vmi_migrations_running kubevirt_migrate_vmi_succeeded to kubevirt_vmi_migrations_succeeded kubevirt_migrate_vmi_failed to kubevirt_vmi_migrations_failed Based on PR kubevirt/kubevirt#9821 Signed-off-by: Shirly Radco <sradco@redhat.com>

Updated live migration metrics names kubevirt_migrate_vmi_data_processed_bytes to kubevirt_vmi_migration_data_processed_bytes kubevirt_migrate_vmi_data_remaining_bytes to kubevirt_vmi_migration_data_remaining_bytes kubevirt_migrate_vmi_dirty_memory_rate_bytes to kubevirt_vmi_migration_memory_transfer_rate_bytes kubevirt_migrate_vmi_pending_count to kubevirt_vmi_migrations_in_pending_phase kubevirt_migrate_vmi_scheduling_count to kubevirt_vmi_migrations_in_scheduling_phase kubevirt_migrate_vmi_running_count to kubevirt_vmi_migrations_in_running_phase kubevirt_migrate_vmi_succeeded to kubevirt_vmi_migration_succeeded kubevirt_migrate_vmi_failed to kubevirt_vmi_migration_failed Based on PR kubevirt/kubevirt#9821 Signed-off-by: Shirly Radco <sradco@redhat.com>

Updated kubevirt metrics names: kubevirt_vmi_vcpu_wait_seconds to kubevirt_vmi_vcpu_wait_seconds_total kubevirt_vmsnapshot_disks_restored_from_source_total to kubevirt_vmsnapshot_disks_restored_from_source kubevirt_vmi_memory_swap_in_traffic_bytes_total to kubevirt_vmi_memory_swap_in_traffic_bytes kubevirt_vmi_memory_swap_out_traffic_bytes_total to kubevirt_vmi_memory_swap_out_traffic_bytes kubevirt_migrate_vmi_data_processed_bytes to kubevirt_vmi_migration_data_processed_bytes kubevirt_migrate_vmi_data_remaining_bytes to kubevirt_vmi_migration_data_remaining_bytes kubevirt_migrate_vmi_dirty_memory_rate_bytes to kubevirt_vmi_migration_memory_transfer_rate_bytes kubevirt_migrate_vmi_pending_count to kubevirt_vmi_migrations_in_pending_phase kubevirt_migrate_vmi_scheduling_count to kubevirt_vmi_migrations_in_scheduling_phase kubevirt_migrate_vmi_running_count to kubevirt_vmi_migrations_in_running_phase kubevirt_migrate_vmi_succeeded to kubevirt_vmi_migration_succeeded kubevirt_migrate_vmi_failed to kubevirt_vmi_migration_failed Based on PR kubevirt/kubevirt#9821 Signed-off-by: Shirly Radco <sradco@redhat.com>

Updated kubevirt_vmi_vcpu_seconds to kubevirt_vmi_vcpu_seconds_total based on PR kubevirt/kubevirt#9821 Signed-off-by: Shirly Radco <sradco@redhat.com>

Updated kubevirt metrics names: kubevirt_vmi_vcpu_wait_seconds to kubevirt_vmi_vcpu_wait_seconds_total kubevirt_vmsnapshot_disks_restored_from_source_total to kubevirt_vmsnapshot_disks_restored_from_source kubevirt_vmi_memory_swap_in_traffic_bytes_total to kubevirt_vmi_memory_swap_in_traffic_bytes kubevirt_vmi_memory_swap_out_traffic_bytes_total to kubevirt_vmi_memory_swap_out_traffic_bytes kubevirt_migrate_vmi_data_processed_bytes to kubevirt_vmi_migration_data_processed_bytes kubevirt_migrate_vmi_data_remaining_bytes to kubevirt_vmi_migration_data_remaining_bytes kubevirt_migrate_vmi_dirty_memory_rate_bytes to kubevirt_vmi_migration_memory_transfer_rate_bytes kubevirt_migrate_vmi_pending_count to kubevirt_vmi_migrations_in_pending_phase kubevirt_migrate_vmi_scheduling_count to kubevirt_vmi_migrations_in_scheduling_phase kubevirt_migrate_vmi_running_count to kubevirt_vmi_migrations_in_running_phase kubevirt_migrate_vmi_succeeded to kubevirt_vmi_migration_succeeded kubevirt_migrate_vmi_failed to kubevirt_vmi_migration_failed Based on PR kubevirt/kubevirt#9821 Signed-off-by: Shirly Radco <sradco@redhat.com>

Update kubevirt-top-consumers dashboard. Replace: kubevirt_vmi_vcpu_wait_seconds -> kubevirt_vmi_vcpu_wait_seconds_total kubevirt_vmi_memory_swap_in_traffic_bytes_total -> kubevirt_vmi_memory_swap_in_traffic_bytes Since the vCPU Wait by Virtual Machines and Memory Swap Traffic by Virtual Machines graphs are also empty on CNV engineering due to the changes in: kubevirt/kubevirt#9821 Signed-off-by: Shirly Radco <sradco@redhat.com>

kubevirt-bot requested review from lyarwood and vladikr May 30, 2023 10:40

sradco force-pushed the update_metrics_names branch from 9669ee1 to a1770d5 Compare May 30, 2023 10:43

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2023

avlitman mentioned this pull request May 30, 2023

Add metrics name linter #9822

Merged

machadovilaca reviewed Jun 7, 2023

View reviewed changes

sradco force-pushed the update_metrics_names branch 2 times, most recently from 8c5fe6a to c335d1a Compare June 12, 2023 20:06

sradco force-pushed the update_metrics_names branch from c335d1a to 1be736d Compare June 25, 2023 13:14

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2023

sradco force-pushed the update_metrics_names branch from 1be736d to 550119b Compare July 23, 2023 12:45

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2023

sradco force-pushed the update_metrics_names branch from 550119b to 7f91ee2 Compare July 23, 2023 13:14

sradco added a commit to sradco/user-guide that referenced this pull request Jul 23, 2023

update metric name

f7b116a

Updated kubevirt_vmi_vcpu_seconds to kubevirt_vmi_vcpu_seconds_total based on PR kubevirt/kubevirt#9821 Signed-off-by: Shirly Radco <sradco@redhat.com>

kubevirt-bot merged commit 7765946 into kubevirt:main Aug 17, 2023
37 of 38 checks passed

This was referenced Aug 22, 2023

[bug-fix] Reference changed without changing the definition #10322

Merged

[release-1.0] update metrics names #10323

Closed

kubevirt-bot pushed a commit to kubevirt/user-guide that referenced this pull request Nov 14, 2023

update metric name (#702)

6e4c579

Updated kubevirt_vmi_vcpu_seconds to kubevirt_vmi_vcpu_seconds_total based on PR kubevirt/kubevirt#9821 Signed-off-by: Shirly Radco <sradco@redhat.com>

sradco mentioned this pull request May 1, 2024

Update kubevirt-top-consumers dashboard kubevirt/monitoring#237

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update metric names to fit metrics naming conventions #9821

Update metric names to fit metrics naming conventions #9821

sradco commented May 30, 2023 •

edited

sradco commented May 30, 2023

sradco commented May 30, 2023

sradco commented May 30, 2023

avlitman commented May 30, 2023 •

edited

sradco commented Jun 1, 2023

avlitman commented Jun 1, 2023

machadovilaca Jun 7, 2023

sradco Jun 12, 2023

sradco commented Jun 12, 2023

sradco commented Jun 14, 2023

sradco commented Jun 14, 2023

sradco commented Jun 14, 2023

lyarwood commented Jun 14, 2023

avlitman commented Aug 17, 2023

sradco commented Aug 17, 2023

avlitman commented Aug 17, 2023

enp0s3 commented Aug 17, 2023

kubevirt-bot commented Aug 17, 2023 •

edited

enp0s3 commented Aug 17, 2023

awels commented Aug 17, 2023

avlitman commented Aug 17, 2023

enp0s3 commented Aug 17, 2023

akalenyu commented Aug 17, 2023

kubevirt-commenter-bot commented Aug 17, 2023

sradco commented Aug 19, 2023

avlitman commented Aug 20, 2023

enp0s3 commented Aug 21, 2023

kubevirt-bot commented Aug 21, 2023

enp0s3 commented Aug 21, 2023

Update metric names to fit metrics naming conventions #9821

Update metric names to fit metrics naming conventions #9821

Conversation

sradco commented May 30, 2023 • edited

sradco commented May 30, 2023

sradco commented May 30, 2023

sradco commented May 30, 2023

avlitman commented May 30, 2023 • edited

sradco commented Jun 1, 2023

avlitman commented Jun 1, 2023

machadovilaca Jun 7, 2023

Choose a reason for hiding this comment

sradco Jun 12, 2023

Choose a reason for hiding this comment

sradco commented Jun 12, 2023

sradco commented Jun 14, 2023

sradco commented Jun 14, 2023

sradco commented Jun 14, 2023

lyarwood commented Jun 14, 2023

avlitman commented Aug 17, 2023

sradco commented Aug 17, 2023

avlitman commented Aug 17, 2023

enp0s3 commented Aug 17, 2023

kubevirt-bot commented Aug 17, 2023 • edited

enp0s3 commented Aug 17, 2023

awels commented Aug 17, 2023

avlitman commented Aug 17, 2023

enp0s3 commented Aug 17, 2023

akalenyu commented Aug 17, 2023

kubevirt-commenter-bot commented Aug 17, 2023

sradco commented Aug 19, 2023

avlitman commented Aug 20, 2023

enp0s3 commented Aug 21, 2023

kubevirt-bot commented Aug 21, 2023

enp0s3 commented Aug 21, 2023

sradco commented May 30, 2023 •

edited

avlitman commented May 30, 2023 •

edited

kubevirt-bot commented Aug 17, 2023 •

edited