New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rule to collect issues with the pods #11557
Conversation
6391ad9
to
8c08654
Compare
8c08654
to
ae78d46
Compare
ae78d46
to
429fb25
Compare
@enp0s3 @iholder101 Will appreciate your review (: |
429fb25
to
365c059
Compare
Please tag someone that's more familiar with monitoring for an initial review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear to me what you're going to do with the collected metrics. Will you use them to fine-tune the default memory requests? What's the impact for users if requests << usage?
23c650c
to
3296b3a
Compare
/lgtm |
d83d7e7
to
ee63b48
Compare
/unhold |
/lgtm |
Signed-off-by: alitman <alitman@alitman-thinkpadp1gen4i.tlv.csb>
ee63b48
to
8ed18b4
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enp0s3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Required labels detected, running phase 2 presubmits: |
@avlitman: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/cherry-pick release-1.2 |
@avlitman: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@avlitman: new pull request created: #11703 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does
Before this PR:
We currently have rules that calculate the available memory for all pods per container.
After this PR:
This pr adds rule that calculate issues with the pods like the memory of the pod with the highest memory exception value by container based on working set/rss memory (in bytes).
For example, if the virt-api container has 2 pods, one of which has an exception rate of 1000 and the other has -2000: the rule will show 1000.
The rules added is
kubevirt_memory_delta_from_requested_bytes
which includes both the working_set and rss memory minus the requested memory, see:**cnv_abnormal added to hco repo, see pr: kubevirt/hyperconverged-cluster-operator#2855
Fixes #
Jira-ticket: https://issues.redhat.com/browse/CNV-39598
Why we need it and why it was done in this way
this pr is the next step after deprecating the KubeVirtComponentExceedsRequestedCPU and KubeVirtComponentExceedsRequestedMemory alerts: kubevirt/monitoring#222.
we need it in order to still track memory exceeded issues and other issues in the future without making noise (like the alerts did)
Links to places where the discussion took place:
The rules calculation discussed widely with cnv maintainers.
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note