Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cnv_abnormal recording rule to telemeter #527

Closed
wants to merge 1 commit into from

Conversation

avlitman
Copy link

Add new recording rule about cnv issues to telemeter, as for now the only issue is memory exceeded.

This pr need to be merged after kubevirt/kubevirt#11557.

Signed-off-by: avlitman <alitman@redhat.com>
@avlitman
Copy link
Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2024
Copy link
Contributor

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: avlitman
Once this PR has been reviewed and has the lgtm label, please assign simonpasquier for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@douglascamata
Copy link
Member

@avlitman please follow the documentation in the README to add more metrics to Telemetry: https://github.com/openshift/telemeter?tab=readme-ov-file#adding-new-metrics-to-send-via-telemeter

@avlitman avlitman changed the title Add cnv_abnormal metric to telemeter Add cnv_abnormal recording rule to telemeter Mar 20, 2024
@avlitman
Copy link
Author

avlitman commented Mar 20, 2024

@avlitman please follow the documentation in the README to add more metrics to Telemetry: https://github.com/openshift/telemeter?tab=readme-ov-file#adding-new-metrics-to-send-via-telemeter

I created https://issues.redhat.com/browse/MON-3763
and pr on cluster-monitoring-operator: openshift/cluster-monitoring-operator#2291

Copy link
Contributor

openshift-ci bot commented Mar 20, 2024

@avlitman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@simonpasquier
Copy link
Contributor

/close
you don't need a PR in telemeter, openshift/cluster-monitoring-operator#2291 suffices

@openshift-ci openshift-ci bot closed this Mar 21, 2024
Copy link
Contributor

openshift-ci bot commented Mar 21, 2024

@simonpasquier: Closed this PR.

In response to this:

/close
you don't need a PR in telemeter, openshift/cluster-monitoring-operator#2291 suffices

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants