Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable coverage for goveralls #5583

Merged
merged 3 commits into from May 12, 2021
Merged

Enable coverage for goveralls #5583

merged 3 commits into from May 12, 2021

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented May 3, 2021

What this PR does / why we need it:
Based on #5262, this PR restores the ability to run goveralls again. This contains the changes to reenable bazel coverage and also enable the go -race flag in order to catch flakyness and data races.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Reenable coverage

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 3, 2021
@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dhiller dhiller mentioned this pull request May 3, 2021
Closed
@dhiller dhiller force-pushed the enable-coverage-for-goveralls branch from a0dd49b to 5949ecd Compare May 10, 2021 13:57
@dhiller
Copy link
Contributor Author

dhiller commented May 10, 2021

/test pull-kubevirt-unit-test
/test pull-kubevirt-goveralls

@dhiller
Copy link
Contributor Author

dhiller commented May 10, 2021

/test pull-kubevirt-unit-test

@dhiller dhiller force-pushed the enable-coverage-for-goveralls branch from 5949ecd to 25a6d08 Compare May 10, 2021 14:37
@dhiller
Copy link
Contributor Author

dhiller commented May 10, 2021

/test pull-kubevirt-unit-test

@dhiller
Copy link
Contributor Author

dhiller commented May 10, 2021

/test pull-kubevirt-goveralls

@dhiller
Copy link
Contributor Author

dhiller commented May 10, 2021

Goveralls succeeded here: https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/5583/pull-kubevirt-goveralls/1391764508879360000

@dhiller dhiller marked this pull request as ready for review May 10, 2021 15:24
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2021
@dhiller dhiller force-pushed the enable-coverage-for-goveralls branch from 25a6d08 to b76839b Compare May 10, 2021 15:31
@dhiller dhiller force-pushed the enable-coverage-for-goveralls branch from b76839b to a962ddc Compare May 11, 2021 07:33
@dhiller dhiller force-pushed the enable-coverage-for-goveralls branch 2 times, most recently from 8496a9e to 3716069 Compare May 11, 2021 08:14
@dhiller
Copy link
Contributor Author

dhiller commented May 11, 2021

/test pull-kubevirt-goveralls

@rmohr
Copy link
Member

rmohr commented May 11, 2021

/lgtm
/approve

/hold

Want to quickly check the unsafeptr disable in nogo. Would prefer if we can keep the check.

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2021
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2021
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label May 11, 2021
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rmohr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2021
@rmohr
Copy link
Member

rmohr commented May 11, 2021

/hold cancel
/lgtm

@kubevirt-bot kubevirt-bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 11, 2021
@dhiller
Copy link
Contributor Author

dhiller commented May 11, 2021

/test pull-kubevirt-build

@dhiller
Copy link
Contributor Author

dhiller commented May 11, 2021

/test pull-kubevirt-goveralls

@dhiller
Copy link
Contributor Author

dhiller commented May 11, 2021

/test pull-kubevirt-e2e-k8s-1.20-sig-compute

@dhiller
Re-enable unit test coverage for goveralls
c7c5bdf 
Enables the race flag in bazel tests. Also adds test.log files output
to artifacts for having more information. Updates the go rules and
gazelle rules for bazel.

Disables unsafeptr nogo rule, as that now
fails, even though it was mentioned in ignored vendor dependencies.

Signed-off-by: Daniel Hiller <dhiller@redhat.com>
@dhiller
Update WORKSPACE and bazel build files
0d75023 
Also update vendor folders

Signed-off-by: Daniel Hiller <dhiller@redhat.com>
@dhiller
Reenable unsafeptr nogo rule
a79ee42 
Add rules_go_work- folder to exclusion rules instead.

Signed-off-by: Daniel Hiller <dhiller@redhat.com>
@dhiller dhiller force-pushed the enable-coverage-for-goveralls branch from c76b0e8 to a79ee42 Compare May 12, 2021 05:09
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label May 12, 2021
@dhiller
Copy link
Contributor Author

dhiller commented May 12, 2021

/test pull-kubevirt-goveralls

@dhiller
Copy link
Contributor Author

dhiller commented May 12, 2021

Had to rebase, PTAL, thanks!

@dhiller
Copy link
Contributor Author

dhiller commented May 12, 2021

/test pull-kubevirt-e2e-k8s-1.20-sig-compute

@rmohr
Copy link
Member

rmohr commented May 12, 2021

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2021
@kubevirt-bot kubevirt-bot merged commit 1636fff into kubevirt:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jean-edouard jean-edouard Awaiting requested review from jean-edouard

@omeryahud omeryahud Awaiting requested review from omeryahud

Assignees

@rmohr rmohr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dhiller @kubevirt-bot @rmohr