[release-0.58] Fix bug in restore-controller when creating a restore PVC with both dataSource and dataSourceRef #8697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ataSource and dataSourceRef Since the dataSourceRef API inclusion in k8s v1.22, a new validation mechanism was added for PVCs ensuring that, if present, both the dataSource and dataSourceRef fields must be equal. This behavior conflicts with the restore-controller, which creates the restore PVC using the source PVC spec as a reference, but overwriting the dataSource field. If the source PVC has a populated dataSourceRef field, just overwriting the dataSource triggers the validation error. This commit modifies this behavior, so both dataSource and dataSourceRef are overwrritten. Signed-off-by: Alvaro Romero <alromero@redhat.com>
Signed-off-by: Alvaro Romero <alromero@redhat.com>
kubevirt-bot
added
release-note-none
|
/test pull-kubevirt-e2e-kind-1.22-sriov-nonroot-0.58 |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enp0s3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/retest-required |
This was referenced Nov 21, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8568
/assign maya-r