Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.58] Backport sig-storage quarantines #9483

Closed
wants to merge 2 commits into from
Closed

[release-0.58] Backport sig-storage quarantines #9483

wants to merge 2 commits into from

Conversation

maya-r
Copy link
Contributor

@maya-r maya-r commented Mar 21, 2023

These tests have been deemed flaky enough on main, let's backport the quarantine to the release branches too.

Release note:

NONE

maya-r and others added 2 commits March 21, 2023 15:34
@maya-r
Quarantine fstrim tests so sig-storage-centos9 can be enabled
cc93978 
These are slightly flaky on the centos9 lane, and we know the feature
works as they sometimes pass. Let's quarantine them so the lane can
be made mandatory for the branch.

Signed-off-by: Maya Rashish <mrashish@redhat.com>
@brianmcarey @maya-r
Quarantine flaky storage test that starts VMI with faulty disk
a637507 
The following test has been impacting the storage test lanes over the
past two weeks:

`Storage Starting a VirtualMachineInstance with faulty disk [It] should
pause VMI on IO error`

As the impact has been greater than 5% over the past 14 days[1], this test
qualifies for quarantine.

This test may also be impacting another storage test[2] so quarantining
will allow to see if this helps to reduce the flakiness.

[1] https://search.ci.kubevirt.io/?search=Starting+a+VirtualMachineInstance+with+faulty+disk&maxAge=336h&context=1&type=build-log&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job
[2] https://github.com/kubevirt/kubevirt/blob/main/tests/storage/storage.go#L159

Signed-off-by: Brian Carey <bcarey@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Mar 21, 2023
@kubevirt-bot
Copy link
Contributor

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vladikr for approval by writing /assign @vladikr in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added area/monitoring kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/build-change Categorizes PRs as related to changing build files of virt-* components sig/network labels Mar 21, 2023
@maya-r maya-r changed the base branch from main to release-0.58 March 21, 2023 15:35
@kubevirt-bot kubevirt-bot added size/XS and removed size/XXL needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 21, 2023
@oshoval
Copy link
Contributor

oshoval commented Mar 21, 2023 •
edited

It is weird that runs here, as this is for main only atm not branches
It seems it is configured just as the previous lane
https://www.diffchecker.com/864FRaGI/

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/9483/pull-kubevirt-e2e-k3d-1.25-sriov/1638204733573304320

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Mar 21, 2023 •
edited

@maya-r: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-unit-test-arm64 a637507 link false /test pull-kubevirt-unit-test-arm64
pull-kubevirt-e2e-arm64 a637507 link false /test pull-kubevirt-e2e-arm64
pull-kubevirt-fossa a637507 link false /test pull-kubevirt-fossa
pull-kubevirt-manifests a637507 link true /test pull-kubevirt-manifests-0.58
pull-kubevirt-prom-rules-verify a637507 link true /test pull-kubevirt-prom-rules-verify-0.58
pull-kubevirt-e2e-k8s-1.26-sig-operator a637507 link true /test pull-kubevirt-e2e-k8s-1.26-sig-operator
pull-kubevirt-e2e-k3d-1.25-sriov a637507 link true /test pull-kubevirt-e2e-k3d-1.25-sriov
pull-kubevirt-e2e-k8s-1.26-sig-storage a637507 link true /test pull-kubevirt-e2e-k8s-1.26-sig-storage
pull-kubevirt-e2e-kind-1.23-vgpu a637507 link true /test pull-kubevirt-e2e-kind-1.23-vgpu-0.58
pull-kubevirt-e2e-k8s-1.25-sig-storage a637507 link true /test pull-kubevirt-e2e-k8s-1.25-sig-storage
pull-kubevirt-e2e-k8s-1.26-sig-compute a637507 link true /test pull-kubevirt-e2e-k8s-1.26-sig-compute
pull-kubevirt-goveralls a637507 link false /test pull-kubevirt-goveralls-0.58
pull-kubevirt-e2e-windows2016 a637507 link true /test pull-kubevirt-e2e-windows2016

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@maya-r
Copy link
Contributor Author

maya-r commented Mar 21, 2023

It is weird that runs here, as this is for main only atm not branches It seems it is configured just as the previous lane https://www.diffchecker.com/864FRaGI/

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/9483/pull-kubevirt-e2e-k3d-1.25-sriov/1638204733573304320

I accidentally made the PR towards main and then changed it. This might be confusing the CI

@maya-r
Copy link
Contributor Author

maya-r commented Mar 21, 2023

Closing because changing branches in the PR seems to be confusing the CI.

@maya-r maya-r closed this Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlonaKaplan AlonaKaplan Awaiting requested review from AlonaKaplan

@kbidarkar kbidarkar Awaiting requested review from kbidarkar

@lyarwood lyarwood Awaiting requested review from lyarwood

@oshoval oshoval Awaiting requested review from oshoval

@rthallisey rthallisey Awaiting requested review from rthallisey

Assignees
No one assigned
Labels
area/monitoring dco-signoff: no Indicates the PR's author has not DCO signed all their commits. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/build-change Categorizes PRs as related to changing build files of virt-* components release-note-none Denotes a PR that doesn't merit a release note. sig/network size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maya-r @kubevirt-bot @oshoval @brianmcarey