Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.58] Add GC note to DataVolumeSource api doc #8761

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/openapi-spec/swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -15632,7 +15632,7 @@
"type": "boolean"
},
"name": {
"description": "Name represents the name of the DataVolume in the same namespace",
"description": "Name of both the DataVolume and the PVC in the same namespace. After PVC population the DataVolume is garbage collected by default.",
"type": "string"
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6359,8 +6359,9 @@ var CRDsValidation map[string]string = map[string]string{
can be hotplugged and hotunplugged.
type: boolean
name:
description: Name represents the name of the DataVolume
in the same namespace
description: Name of both the DataVolume and the PVC in
the same namespace. After PVC population the DataVolume
is garbage collected by default.
type: string
required:
- name
Expand Down Expand Up @@ -6898,8 +6899,9 @@ var CRDsValidation map[string]string = map[string]string{
can be hotplugged and hotunplugged.
type: boolean
name:
description: Name represents the name of the DataVolume
in the same namespace
description: Name of both the DataVolume and the PVC in
the same namespace. After PVC population the DataVolume
is garbage collected by default.
type: string
required:
- name
Expand Down Expand Up @@ -10449,8 +10451,9 @@ var CRDsValidation map[string]string = map[string]string{
hotplugged and hotunplugged.
type: boolean
name:
description: Name represents the name of the DataVolume in the
same namespace
description: Name of both the DataVolume and the PVC in the same
namespace. After PVC population the DataVolume is garbage collected
by default.
type: string
required:
- name
Expand Down Expand Up @@ -14945,8 +14948,9 @@ var CRDsValidation map[string]string = map[string]string{
can be hotplugged and hotunplugged.
type: boolean
name:
description: Name represents the name of the DataVolume
in the same namespace
description: Name of both the DataVolume and the PVC in
the same namespace. After PVC population the DataVolume
is garbage collected by default.
type: string
required:
- name
Expand Down Expand Up @@ -18967,8 +18971,9 @@ var CRDsValidation map[string]string = map[string]string{
volume can be hotplugged and hotunplugged.
type: boolean
name:
description: Name represents the name of the DataVolume
in the same namespace
description: Name of both the DataVolume and the
PVC in the same namespace. After PVC population
the DataVolume is garbage collected by default.
type: string
required:
- name
Expand Down Expand Up @@ -23665,8 +23670,10 @@ var CRDsValidation map[string]string = map[string]string{
the volume can be hotplugged and hotunplugged.
type: boolean
name:
description: Name represents the name of the
DataVolume in the same namespace
description: Name of both the DataVolume and
the PVC in the same namespace. After PVC
population the DataVolume is garbage collected
by default.
type: string
required:
- name
Expand Down Expand Up @@ -24256,8 +24263,10 @@ var CRDsValidation map[string]string = map[string]string{
the volume can be hotplugged and hotunplugged.
type: boolean
name:
description: Name represents the name of the
DataVolume in the same namespace
description: Name of both the DataVolume and
the PVC in the same namespace. After PVC
population the DataVolume is garbage collected
by default.
type: string
required:
- name
Expand Down
3 changes: 2 additions & 1 deletion staging/src/kubevirt.io/api/core/v1/schema.go
Original file line number Diff line number Diff line change
Expand Up @@ -774,7 +774,8 @@ type HotplugVolumeSource struct {
}

type DataVolumeSource struct {
// Name represents the name of the DataVolume in the same namespace
// Name of both the DataVolume and the PVC in the same namespace.
// After PVC population the DataVolume is garbage collected by default.
Name string `json:"name"`
// Hotpluggable indicates whether the volume can be hotplugged and hotunplugged.
// +optional
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion staging/src/kubevirt.io/client-go/api/openapi_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.