Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.58] Add GC note to DataVolumeSource api doc #8761

Merged
merged 1 commit into from
Mar 20, 2023
Merged

[release-0.58] Add GC note to DataVolumeSource api doc #8761

merged 1 commit into from
Mar 20, 2023

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #8726

/assign arnongilboa

NONE

@arnongilboa
Add GC note to DataVolumeSource api doc
82e1f29 
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
@kubevirt-bot kubevirt-bot mentioned this pull request Nov 10, 2022
Merged
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Nov 10, 2022
@arnongilboa
Copy link
Contributor

/retest-required

@arnongilboa
Copy link
Contributor

/test pull-kubevirt-e2e-k8s-1.24-sig-compute-0.58
/test pull-kubevirt-goveralls-0.58

ShellyKa13
ShellyKa13 reviewed Nov 15, 2022
View reviewed changes
Copy link
Contributor

@ShellyKa13 ShellyKa13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2022
@arnongilboa
Copy link
Contributor

/assign @rmohr

@kubevirt-bot
Copy link
Contributor Author

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 13, 2023
@kubevirt-bot
Copy link
Contributor Author

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubevirt-bot kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 15, 2023
@xpivarc
Copy link
Member

xpivarc commented Mar 17, 2023

@mhenriks @awels

@awels
Copy link
Member

awels commented Mar 17, 2023

/lgtm

@mhenriks
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2023
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit 8527bfe into kubevirt:release-0.58 Mar 20, 2023
@kubevirt-bot kubevirt-bot mentioned this pull request Mar 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShellyKa13 ShellyKa13 ShellyKa13 left review comments

@AlonaKaplan AlonaKaplan Awaiting requested review from AlonaKaplan

@rmohr rmohr Awaiting requested review from rmohr

Assignees

@awels awels

@rmohr rmohr

@arnongilboa arnongilboa

@ShellyKa13 ShellyKa13

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@kubevirt-bot @arnongilboa @xpivarc @awels @mhenriks @kubevirt-commenter-bot @ShellyKa13 @rmohr