[release-0.58] instancetype, snapshot: Capture and restore instancetype ControllerRevisions #8810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Itamar Holder <iholder@redhat.com>
This change introduces the cloning of any referenced instancetype ControllerRevisions from the source VirtualMachine during a snapshot. The resulting cloned ControllerRevisions are then referenced from the VirtualMachine stored within the created VirtualMachineSnapshotContent resource. A following change will introduce support on the restore side to again clone these ControllerRevisions for use by the resulting VirtualMachine. Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
Building on previous changes that essentially cloned any referenced instancetype or preference ControllerRevisions during the creation of a VirtualMachineSnapshot we can now restore these into the existing or new VirtualMachine. When restoring for use by a new VirtualMachine we need to ensure that the newly created ControllerRevisions are claimed by the new VirtualMachine once it has been created. Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
Conflicts: tests/clone_test.go NOTE(lyarwood): generateCloneFromVM is replaced with generateClone as 09b5824 isn't present on the v0.58.0 branch. Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
GenerateKubeVirtGroupVersionKind ensures a provided object registered with KubeVirts generated schema has GVK set correctly. This is required as client-go continues to return objects without TypeMeta set as set out in the following closed but often cited issue: Object's TypeMeta is empty kubernetes/client-go#413 Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
kubevirt-bot
added
the
release-note-none
kubevirt-bot
added
area/instancetype
dco-signoff: yes
|
/lgtm |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidvossel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/retest-required |
This was referenced Nov 21, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
/area instancetype
/cc @0xFelix
/cc @davidvossel
/cc @iholder-redhat
This is a manual cherry-pick of #8466
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: