Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.58] instancetype: Ignore unexpected existing CRs during restore #8912

Merged
merged 2 commits into from
Dec 13, 2022
Merged

[release-0.58] instancetype: Ignore unexpected existing CRs during restore #8912

merged 2 commits into from
Dec 13, 2022

Commits on Dec 6, 2022

  1. Add regression test for bug kubevirt#8890 

    Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
    @lyarwood
    lyarwood authored and kubevirt-bot committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    2994697 View commit details
    Browse the repository at this point in the history

  2. instancetype: Ignore unexpected existing CRs during restore 

    5cc62c0 failed to accommodate repeat
attempts to reconcile a VirtualMachineRestore that in turn lead to
multiple calls to restoreInstancetypeControllerRevision being made for
the same ControllerRevision.

This change handles this case by ignoring any existing
ControllerRevisions found during the restore, assuming that the existing
ControllerRevision was created by a previous call to
restoreInstancetypeControllerRevision.

Future changes will check the contents of this ControllerRevision
against that of the VirtualMachineSnapshot to ensure they match.

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
    @lyarwood
    lyarwood authored and kubevirt-bot committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    3fea23f View commit details
    Browse the repository at this point in the history